Skip to content

Commit

Permalink
.github/workflows/build-pr.yml: Remove colon from job names
Browse files Browse the repository at this point in the history
Having a colon in the name makes it impossible to add the job to the
branch rules.

After consulting with github support, it seems renaming is the most
straightforward solution.
  • Loading branch information
t-b committed Dec 13, 2024
1 parent cd07771 commit c2c6837
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions .github/workflows/build-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,7 @@ jobs:
run: tools/pre-commit/run.sh

CompilationTest:
name: |
πŸ‘©πŸΎβ€πŸ”¬ Compilation: ${{ matrix.source }} ${{ fromJSON('["","with XOP"]')[matrix.hardware] }}
name: πŸ‘©πŸΎβ€πŸ”¬ Compilation of ${{ matrix.source }} ${{ fromJSON('["","with XOP"]')[matrix.hardware] }}
needs:
- BuildInstaller
strategy:
Expand All @@ -130,8 +129,7 @@ jobs:
hardware: false
uses: ./.github/workflows/test-igor-workflow.yml
with:
job_name: |
πŸ‘©πŸΎβ€πŸ”¬ Compilation: ${{ matrix.source }} ${{ fromJSON('["","with XOP"]')[matrix.hardware] }}
job_name: πŸ‘©πŸΎβ€πŸ”¬ Compilation of ${{ matrix.source }} ${{ fromJSON('["","with XOP"]')[matrix.hardware] }}
overwrite_job_name: ${{ inputs.is_called_workflow || false }}
experiment: Packages/tests/Compilation/CompilationTester.pxp
installer_artifact_name: BuildInstaller-dev-assets
Expand All @@ -140,13 +138,11 @@ jobs:
timeout_minutes: 60

CompilationEachCommitTest:
name: |
πŸ‘©πŸΎβ€πŸ”¬ Compilation: Each commit
name: πŸ‘©πŸΎβ€πŸ”¬ Compilation of each commit
if: ${{ !inputs.is_called_workflow }}
uses: ./.github/workflows/test-igor-rebase-exec-workflow.yml
with:
job_name: |
πŸ‘©πŸΎβ€πŸ”¬ Compilation: Each commit
job_name: πŸ‘©πŸΎβ€πŸ”¬ Compilation of each commit
overwrite_job_name: ${{ inputs.is_called_workflow || false }}
experiment: Packages/tests/Compilation/CompilationTester.pxp
installer_flags: "-s git"
Expand Down

0 comments on commit c2c6837

Please sign in to comment.