forked from ZhuangLab/MERFISH_analysis
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yilinzhao #7
Open
yilinzhao1615
wants to merge
14
commits into
master
Choose a base branch
from
yilinzhao
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Yilinzhao #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this version works with LIMS references changed "transferAbund" to "true" under "if useUniformWeights" output the same probes each run
The human_MTG sequential codebook revealed a bug that the allOligos were not collected correctly with the original version. I rewrote the logic to collect allOligos.
1. Check whether gene and ids match with each other in the reference, send a warning if not 2. allOligos file is written in a different way to avoid empty cells when there are mismatched gene+ids in the codebook 3. change the selection process of probes to stop picking duplicated probes for genes with multiple transcripts
Tested. We can keep the ensemble and NCBI choice as long as we remove the NCBI _ to , modification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to add an output csv with genes and number of probes designed per gene