Ticket/PSB-7 #2730
Merged
Ticket/PSB-7 #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
morriscb
force-pushed
the
ticket/PSB-7/dev
branch
from
7562e3c to
64e5a18
Compare
aamster
approved these changes
Nov 2, 2023
Improve metadata symmetry of typing between S3 load and LIMS. Add column order to lims.
Clean up language.
morriscb
force-pushed
the
ticket/PSB-7/dev
branch
from
05c6962 to
6fe632e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unskipping lims consistency test.
Test actually checks for consistency between the LIMS loaded metadata table and a csv file loaded into the cloud cache object. To get the test to pass required moving around and adding the enforce_int_typing/column order functions for both the cloud cache and the lims cache objects.