Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Awesome update #780

Open
wants to merge 5 commits into
base: v3.0.0-dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,13 @@ Finally, you need to import the css file to your app, there are two css file you
```
The CSS files you can find in the css folder.

### d.Font Awesome js
The package uses since v 3.0 [Font Awesome](http://fontawesome.io/) for icons. In order to install you must get a CDN [by registering](http://fontawesome.io/get-started/) or use the [font-awesome package](https://www.npmjs.com/package/font-awesome). Then in the header you need to add (use your own js-link instead of the `???`):

```html
<script src="https://use.fontawesome.com/???.js"></script>
```

### Quick Demo
```js
// products will be presented by react-bootstrap-table
Expand All @@ -118,7 +125,7 @@ var products = [{
},........];
// It's a data format example.
function priceFormatter(cell, row){
return '<i class="glyphicon glyphicon-usd"></i> ' + cell;
return '<i class="fa fa-usd"></i> ' + cell;
}

React.render(
Expand Down
2 changes: 1 addition & 1 deletion examples/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<title>react-bootstrap-table demo</title>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.2/css/bootstrap.min.css">
<script src="http://code.jquery.com/jquery-2.1.3.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.2/js/bootstrap.js"></script>
<script src="https://use.fontawesome.com/f52b8fd2c4.js"></script>
</head>
<body>
<div id="root"></div>
Expand Down
2 changes: 1 addition & 1 deletion examples/js/cell-edit/custom-cell-edit-table.js
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ class RegionsEditor extends React.Component {
}

function priceFormatter(cell, row) {
return `<i class='glyphicon glyphicon-${cell.currency.toLowerCase()}'></i> ${cell.amount}`;
return `<i class='fa fa-${cell.currency.toLowerCase()}'></i> ${cell.amount}`;
}

const regionsFormatter = (cell, row) => (<span>{ (cell || []).join(',') }</span>);
Expand Down
2 changes: 1 addition & 1 deletion examples/js/column-format/html-column-format-table.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ addProducts(5);


function priceFormatter(cell, row) {
return `<i class='glyphicon glyphicon-usd'></i> ${cell}`;
return `<i class='fa fa-usd'></i> ${cell}`;
}


Expand Down
2 changes: 1 addition & 1 deletion examples/js/custom/csv-button/default-custom-csv-button.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default class DefaultCustomExportButtonTable extends React.Component {
btnText='CustomExportText'
btnContextual='btn-danger'
className='my-custom-class'
btnGlyphicon='glyphicon-edit'
btnFAwesome='fa-edit'
onClick={ e => this.handleExportCSVButtonClick(onClick) }/>
);
// If you want have more power to custom the child of ExportCSVButton,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default class DefaultCustomInsertButtonTable extends React.Component {
btnText='CustomDeleteText'
btnContextual='btn-success'
className='my-custom-class'
btnGlyphicon='glyphicon-edit'
btnFAwesome='fa-edit'
onClick={ e => this.handleDeleteButtonClick(onClick) }/>
);
// If you want have more power to custom the child of DeleteButton,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export default class DefaultCustomInsertButtonTable extends React.Component {
btnText='CustomInsertText'
btnContextual='btn-warning'
className='my-custom-class'
btnGlyphicon='glyphicon-edit'
btnFAwesome='fa-edit'
onClick={ () => this.handleInsertButtonClick(onClick) }/>
);
// If you want have more power to custom the child of InsertButton,
Expand Down
4 changes: 2 additions & 2 deletions examples/js/manipulation/search-format-table.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const products = [];
function addProducts(quantity) {
const startId = products.length;
const pname = [ 'Cloud Service', 'Message Service', 'Add Service', 'Edit Service', 'Money' ];
const icons = [ 'glyphicon-cloud', 'glyphicon-envelope', 'glyphicon-plus', 'glyphicon-pencil', 'glyphicon-euro' ];
const icons = [ 'fa-cloud', 'fa-envelope', 'fa-plus', 'fa-pencil', 'fa-euro' ];
const types = [ 'Cloud', 'Mail', 'Insert', 'Modify', 'Money' ];
const years = [ 2005, 2006, 2008, 2001, 2015 ];
for (let i = 0; i < quantity; i++) {
Expand All @@ -36,7 +36,7 @@ function filterType(cell, row) {
}

function nameFormatter(cell) {
return `<p><span class='glyphicons ${cell.icon}' aria-hidden='true'></span> ${cell.pname}, from ${cell.year}</p>`;
return `<p><i class='fa fa-${cell.icon}'></i> ${cell.pname}, from ${cell.year}</p>`;
}

function priceFormatter(cell) {
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"react-bootstrap": "^0.29.5",
"react-dom": "^0.14.3 || ^15.0.0",
"react-hot-loader": "^1.3.0",
"react-router": "^1.0.2",
"react-router": "^2.8.1",
"style-loader": "^0.13.0",
"toastr": "^2.1.2",
"vinyl-source-stream": "^1.1.0",
Expand All @@ -64,8 +64,8 @@
},
"dependencies": {
"classnames": "^2.1.2",
"react-toastr": "^2.8.0",
"react-modal": "^1.4.0"
"react-modal": "^1.4.0",
"react-toastr": "^2.8.0"
},
"peerDependencies": {
"react": "^0.14.3 || ^15.0.0"
Expand Down
8 changes: 4 additions & 4 deletions src/toolbar/DeleteButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ class DeleteButton extends Component {
btnContextual,
className,
onClick,
btnGlyphicon,
btnFAwesome,
btnText,
children,
...rest
} = this.props;
const content = children ||
(<span><i className={ `glyphicon ${btnGlyphicon}` }></i> { btnText }</span>);
(<span><i className={ `fa ${btnFAwesome}` }></i> { btnText }</span>);
return (
<button type='button'
className={ `btn ${btnContextual} ${deleteBtnDefaultClass} ${className}` }
Expand All @@ -32,14 +32,14 @@ DeleteButton.propTypes = {
btnContextual: PropTypes.string,
className: PropTypes.string,
onClick: PropTypes.func,
btnGlyphicon: PropTypes.string
btnFAwesome: PropTypes.string
};
DeleteButton.defaultProps = {
btnText: Const.DELETE_BTN_TEXT,
btnContextual: 'btn-warning',
className: '',
onClick: undefined,
btnGlyphicon: 'glyphicon-trash'
btnFAwesome: 'fa-trash'
};

export default DeleteButton;
8 changes: 4 additions & 4 deletions src/toolbar/ExportCSVButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ class ExportCSVButton extends Component {
btnContextual,
className,
onClick,
btnGlyphicon,
btnFAwesome,
btnText,
children,
...rest
} = this.props;
const content = children ||
(<span><i className={ `glyphicon ${btnGlyphicon}` }></i> { btnText }</span>);
(<span><i className={ `fa ${btnFAwesome}` }></i> { btnText }</span>);
return (
<button type='button'
className={ `btn ${btnContextual} ${exportCsvBtnDefaultClass} ${className} hidden-print` }
Expand All @@ -32,14 +32,14 @@ ExportCSVButton.propTypes = {
btnContextual: PropTypes.string,
className: PropTypes.string,
onClick: PropTypes.func,
btnGlyphicon: PropTypes.string
btnFAwesome: PropTypes.string
};
ExportCSVButton.defaultProps = {
btnText: Const.EXPORT_CSV_TEXT,
btnContextual: 'btn-success',
className: '',
onClick: undefined,
btnGlyphicon: 'glyphicon-export'
btnFAwesome: 'fa-arrow-circle-down'
};

export default ExportCSVButton;
8 changes: 4 additions & 4 deletions src/toolbar/InsertButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ class InsertButton extends Component {
btnContextual,
className,
onClick,
btnGlyphicon,
btnFAwesome,
btnText,
children,
...rest
} = this.props;
const content = children ||
(<span><i className={ `glyphicon ${btnGlyphicon}` }></i>{ btnText }</span>);
(<span><i className={ `fa ${btnFAwesome}` }></i> { btnText }</span>);
return (
<button type='button'
className={ `btn ${btnContextual} ${insertBtnDefaultClass} ${className}` }
Expand All @@ -32,14 +32,14 @@ InsertButton.propTypes = {
btnContextual: PropTypes.string,
className: PropTypes.string,
onClick: PropTypes.func,
btnGlyphicon: PropTypes.string
btnFAwesome: PropTypes.string
};
InsertButton.defaultProps = {
btnText: Const.INSERT_BTN_TEXT,
btnContextual: 'btn-info',
className: '',
onClick: undefined,
btnGlyphicon: 'glyphicon-plus'
btnFAwesome: 'fa-plus'
};

export default InsertButton;