Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky Headers #1203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

vKyrylenko
Copy link

Hello, I added a functionality for having sticky headers. To show it there needs to be set a stickyHeaders={ true } as props.
I also added an example you can find it here react-bootstrap-table\examples\js\others\table-with-sticky-headers.js

@AllenFang
Copy link
Owner

@walkman2058, it's a cool feature, but did we have a chance that dont use the react-overlays? Thanks 👍

@vKyrylenko
Copy link
Author

I think that it is possible, but it will require additional functionality/component with the same functionality for calculation position, affix, offsetTop, offsetBottom as in react-overlays.
Why are you against using react-overlays ?

@AllenFang
Copy link
Owner

AllenFang commented Apr 12, 2017

@vKyrylenko, because I dont want to add too many dependency into this lib. I doesn't look into you code to see how it work, but if we can make this cool feature plugable or use it as decorator or HOC will be good.

My final goal is if the user want to sticky-headers, they can use/install react-overlays in their repo and use a HOC or decorator with react-bootstrap-table to have this kind of feature, so that means, native react-bootstrap-table doesn't support sticky-headers and no dependency with react-overlays (But we give you a change to do it, but not support it directly).

That's what I think, and It's a dream and most likely is hard to achieve, because I dont have a good components design now and actually I don't start to think how to implement it, it just a idea.

I'll spend sometime to toward this goal for your PR in these days and let me know if you have any idea.

@FloMaetschke
Copy link

What happened to this now?

@FloMaetschke
Copy link

It would be nice, to be able to specify the docking top height, e.g. if there is a navbar docked already to place the thead below it.

@AllenFang
Copy link
Owner

@FloMaetschke react-bootstrap-table already stop implement new feature and move to react-bootstrap-table2. I will consider to implement sticky header seriously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants