Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Wave.shift() to output wav file #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Apply Wave.shift() to output wav file #91

wants to merge 1 commit into from

Conversation

zhufengning
Copy link

Adjust zs when ts doesn't start from zero

@zhufengning
Apply Wave.shift() to output wav file
813e2ea 
Adjust `zs` when `ts` doesn't start from zero
@AllenDowney
Copy link
Owner

Thanks for this suggestion, but I'm not sure I understand the motivation. What problem does this solve?

@zhufengning
Copy link
Author

Wave.shift adds the value to ts array, but when writing wav file, it doesn't consider values in ts array, so it will write a not shifted wav file.

@AllenDowney
Copy link
Owner

Should the wav file be shifted? What goes wrong if it's not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhufengning @AllenDowney