feat: refine effects behaviour #429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartcmd
requested changes
Oct 4, 2024
| * | ||
| * @return {@code true} if the player is in adventure mode, {@code false} otherwise. | ||
| */ | ||
| default boolean isAdventure() { |
There was a problem hiding this comment.
No need to introduce such a method
| * | ||
| * @param form The form to add. | ||
| */ | ||
| void setServerSettingForm(CustomForm form); | ||
| void addServerSettingForm(CustomForm form); |
|
|
||
| @Override | ||
| public void onEntityDamage(Entity entity, EffectInstance effectInstance, DamageContainer damage) { | ||
| if (Math.random() <= 0.1) { |
| * | ||
| * @return {@code true} if the entity is an Undead mob, otherwise {@code false}. | ||
| */ | ||
| default boolean isUndead() { |
There was a problem hiding this comment.
Find a better way to do that...? For example add an EntityUndeadComponent and use instanceof here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically complete the implementation of all effects except Conduit Power, Bad Omen, Trial Omen, Raid Omen, Hero of the Village, and Wind Charged.