Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic behaviour for falling blocks #278

Merged
merged 4 commits into from
Jun 29, 2024
Merged

Conversation

IWareQ
Copy link
Member

@IWareQ IWareQ commented Jun 28, 2024

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 20.17544% with 91 lines in your changes missing coverage. Please review.

Files Coverage Δ Complexity Δ
...llaymc/server/block/type/BlockTypeInitializer.java 99.83% <100.00%> (-0.02%) 14.00 <2.00> (-53.00)
...aymc/server/entity/type/EntityTypeInitializer.java 96.77% <100.00%> (+0.77%) 4.00 <1.00> (+1.00)
...tity/component/common/EntityBaseComponentImpl.java 15.95% <0.00%> (-0.31%) 11.00 <0.00> (ø)
...ock/component/sand/BlockSandBaseComponentImpl.java 22.22% <22.22%> (ø) 1.00 <1.00> (?)
...laymc/server/command/defaults/GameTestCommand.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...mponent/common/BlockFallableBaseComponentImpl.java 6.66% <6.66%> (ø) 1.00 <1.00> (?)
...lingblock/EntityFallingBlockBaseComponentImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)

... and 12 files with indirect coverage changes

@smartcmd
Copy link
Member

Is this pr ready?

@IWareQ
Copy link
Member Author

IWareQ commented Jun 29, 2024

Is this pr ready?

basic functional - yes

@smartcmd smartcmd merged commit 7ead257 into master Jun 29, 2024
1 of 2 checks passed
@IWareQ IWareQ deleted the feat/falling-blocks branch July 16, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants