Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove specified sid #5127

Merged
merged 2 commits into from
Nov 19, 2024
Merged

chore: remove specified sid #5127

merged 2 commits into from
Nov 19, 2024

Conversation

xingyaoww
Copy link
Collaborator

@xingyaoww xingyaoww commented Nov 19, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

Specifying SID won't work on RemoteRuntime - so we'd better stop manually setting the sid unless we know what we are doing.


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:c1be2a4-nikolaik   --name openhands-app-c1be2a4   docker.all-hands.dev/all-hands-ai/openhands:c1be2a4

@xingyaoww xingyaoww enabled auto-merge (squash) November 19, 2024 16:36
@xingyaoww xingyaoww merged commit ff84a3e into main Nov 19, 2024
14 checks passed
@xingyaoww xingyaoww deleted the xw/remove-sid branch November 19, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants