-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace pexpect with libtmux in BashSession #4881
base: main
Are you sure you want to change the base?
Commits on Nov 10, 2024
-
refactor: Replace pexpect with libtmux in BashSession
- Simplified implementation using libtmux instead of pexpect - Added proper handling of command errors, interactive commands, and timeouts - Added test suite to verify behavior - Improved output handling and error detection
Configuration menu - View commit details
-
Copy full SHA for 7b86e33 - Browse repository at this point
Copy the full SHA 7b86e33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e5653c - Browse repository at this point
Copy the full SHA 9e5653cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 522eb53 - Browse repository at this point
Copy the full SHA 522eb53View commit details -
Configuration menu - View commit details
-
Copy full SHA for d60065b - Browse repository at this point
Copy the full SHA d60065bView commit details -
greatly simplify command to not accepting blocking/keep_prompt, we sh…
…ould do it in the CmdOutputObservation end for keep_prompt
Configuration menu - View commit details
-
Copy full SHA for e304973 - Browse repository at this point
Copy the full SHA e304973View commit details -
Configuration menu - View commit details
-
Copy full SHA for c743833 - Browse repository at this point
Copy the full SHA c743833View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49eae72 - Browse repository at this point
Copy the full SHA 49eae72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 363b379 - Browse repository at this point
Copy the full SHA 363b379View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffa0676 - Browse repository at this point
Copy the full SHA ffa0676View commit details -
Configuration menu - View commit details
-
Copy full SHA for 554e03a - Browse repository at this point
Copy the full SHA 554e03aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b252e0 - Browse repository at this point
Copy the full SHA 2b252e0View commit details -
Improve test coverage for CmdOutputMetadata
- Add tests for missing fields in PS1 metadata - Add tests for malformed values in numeric fields - Add tests for boolean values in numeric fields - Fix JSON parsing in test_ps1_metadata_json_structure - Fix handling of malformed values in from_ps1_match
Configuration menu - View commit details
-
Copy full SHA for e994620 - Browse repository at this point
Copy the full SHA e994620View commit details -
Refactor error handling in CmdOutputMetadata
- Move error handling from from_ps1_match to from_ps1 - Let from_ps1_match raise exceptions for invalid data - Update tests to match new error handling behavior
Configuration menu - View commit details
-
Copy full SHA for 1935483 - Browse repository at this point
Copy the full SHA 1935483View commit details
Commits on Nov 11, 2024
-
Improve CmdOutputMetadata handling of malformed values and line endings
- Add support for float values in numeric fields - Fix regex pattern to handle different line endings - Add more test cases for edge cases - Keep valid string fields when numeric fields fail to parse
Configuration menu - View commit details
-
Copy full SHA for 23ddbe4 - Browse repository at this point
Copy the full SHA 23ddbe4View commit details -
Refactor PS1 metadata regex pattern
- Use re.escape() to properly escape special characters in markers - Use constants to avoid duplication - Update tests to use constants and handle newlines consistently
Configuration menu - View commit details
-
Copy full SHA for 744938c - Browse repository at this point
Copy the full SHA 744938cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5518bf - Browse repository at this point
Copy the full SHA f5518bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for aaed596 - Browse repository at this point
Copy the full SHA aaed596View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71e4ec5 - Browse repository at this point
Copy the full SHA 71e4ec5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a2443f - Browse repository at this point
Copy the full SHA 3a2443fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ceb0d32 - Browse repository at this point
Copy the full SHA ceb0d32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 145f141 - Browse repository at this point
Copy the full SHA 145f141View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56e4df5 - Browse repository at this point
Copy the full SHA 56e4df5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e43ee5 - Browse repository at this point
Copy the full SHA 9e43ee5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed382c6 - Browse repository at this point
Copy the full SHA ed382c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e4180f - Browse repository at this point
Copy the full SHA 8e4180fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c68c7d - Browse repository at this point
Copy the full SHA 3c68c7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d82c420 - Browse repository at this point
Copy the full SHA d82c420View commit details -
Configuration menu - View commit details
-
Copy full SHA for 010e453 - Browse repository at this point
Copy the full SHA 010e453View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4aeb681 - Browse repository at this point
Copy the full SHA 4aeb681View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28615cd - Browse repository at this point
Copy the full SHA 28615cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9aa3e47 - Browse repository at this point
Copy the full SHA 9aa3e47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 959733c - Browse repository at this point
Copy the full SHA 959733cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 210303c - Browse repository at this point
Copy the full SHA 210303cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e050ceb - Browse repository at this point
Copy the full SHA e050cebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8db543d - Browse repository at this point
Copy the full SHA 8db543dView commit details -
Improve test coverage for BashSession
- Add test for session initialization with custom working directory and username - Add test for pwd property updates - Add test for special characters in command output - Add test for multiple commands in sequence - Add test for long-running commands with output - Add test for multiline command input - Add test for ANSI escape codes - Add test for long output
Configuration menu - View commit details
-
Copy full SHA for 3dd21fa - Browse repository at this point
Copy the full SHA 3dd21faView commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for efc481f - Browse repository at this point
Copy the full SHA efc481fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03ba929 - Browse repository at this point
Copy the full SHA 03ba929View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92b2b0c - Browse repository at this point
Copy the full SHA 92b2b0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fec3083 - Browse repository at this point
Copy the full SHA fec3083View commit details -
Configuration menu - View commit details
-
Copy full SHA for a28212b - Browse repository at this point
Copy the full SHA a28212bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f03de49 - Browse repository at this point
Copy the full SHA f03de49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42b69a3 - Browse repository at this point
Copy the full SHA 42b69a3View commit details
Commits on Nov 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4ee07fe - Browse repository at this point
Copy the full SHA 4ee07feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99ef1ef - Browse repository at this point
Copy the full SHA 99ef1efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34a14fd - Browse repository at this point
Copy the full SHA 34a14fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3ae9cf - Browse repository at this point
Copy the full SHA c3ae9cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3affa77 - Browse repository at this point
Copy the full SHA 3affa77View commit details -
Configuration menu - View commit details
-
Copy full SHA for d90a338 - Browse repository at this point
Copy the full SHA d90a338View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d47241 - Browse repository at this point
Copy the full SHA 4d47241View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e1f12b - Browse repository at this point
Copy the full SHA 3e1f12bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0df9ba2 - Browse repository at this point
Copy the full SHA 0df9ba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebeccc6 - Browse repository at this point
Copy the full SHA ebeccc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa351fe - Browse repository at this point
Copy the full SHA fa351feView commit details
Commits on Nov 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0c14a80 - Browse repository at this point
Copy the full SHA 0c14a80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77b4c7c - Browse repository at this point
Copy the full SHA 77b4c7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc3428a - Browse repository at this point
Copy the full SHA bc3428aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a8ff37 - Browse repository at this point
Copy the full SHA 7a8ff37View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9f37ad - Browse repository at this point
Copy the full SHA f9f37adView commit details -
Configuration menu - View commit details
-
Copy full SHA for fae1185 - Browse repository at this point
Copy the full SHA fae1185View commit details -
Configuration menu - View commit details
-
Copy full SHA for 184794a - Browse repository at this point
Copy the full SHA 184794aView commit details
Commits on Nov 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e1c2ac2 - Browse repository at this point
Copy the full SHA e1c2ac2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fce1b07 - Browse repository at this point
Copy the full SHA fce1b07View commit details -
Configuration menu - View commit details
-
Copy full SHA for fab1438 - Browse repository at this point
Copy the full SHA fab1438View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7aee63 - Browse repository at this point
Copy the full SHA c7aee63View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5d23b3 - Browse repository at this point
Copy the full SHA f5d23b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88658dd - Browse repository at this point
Copy the full SHA 88658ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25ae18c - Browse repository at this point
Copy the full SHA 25ae18cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 488a1a7 - Browse repository at this point
Copy the full SHA 488a1a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c173a03 - Browse repository at this point
Copy the full SHA c173a03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bb9f82 - Browse repository at this point
Copy the full SHA 1bb9f82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7752a94 - Browse repository at this point
Copy the full SHA 7752a94View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd94759 - Browse repository at this point
Copy the full SHA cd94759View commit details -
Configuration menu - View commit details
-
Copy full SHA for d491e47 - Browse repository at this point
Copy the full SHA d491e47View commit details -
Revert "feat: implement keep_prompt handling in BashSession and add t…
…ests" This reverts commit d491e47.
Configuration menu - View commit details
-
Copy full SHA for d76bbfa - Browse repository at this point
Copy the full SHA d76bbfaView commit details -
Revert "feat: add keep_prompt parameter to CmdRunAction"
This reverts commit cd94759.
Configuration menu - View commit details
-
Copy full SHA for 4d1c742 - Browse repository at this point
Copy the full SHA 4d1c742View commit details -
refactor: move prefix/suffix to CmdOutputMetadata
- Add prefix and suffix fields to CmdOutputMetadata - Update bash.py to use metadata fields instead of string concatenation - Update CmdOutputObservation to use metadata fields in to_agent_observation
Configuration menu - View commit details
-
Copy full SHA for 51d0bcb - Browse repository at this point
Copy the full SHA 51d0bcbView commit details -
test: update test_bash_session.py to verify prefix/suffix fields
- Add assertions for prefix and suffix fields in all test cases - Move message strings from content assertions to suffix assertions - Add empty prefix assertions where appropriate - Update error message test to match exact content - Add prefix assertions for continuation messages - Add suffix assertions for timeout and completion messages
Configuration menu - View commit details
-
Copy full SHA for fa714a4 - Browse repository at this point
Copy the full SHA fa714a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53d2de2 - Browse repository at this point
Copy the full SHA 53d2de2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fefabd1 - Browse repository at this point
Copy the full SHA fefabd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5001a3 - Browse repository at this point
Copy the full SHA e5001a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c00bd6 - Browse repository at this point
Copy the full SHA 9c00bd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ef9e37 - Browse repository at this point
Copy the full SHA 7ef9e37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20721e3 - Browse repository at this point
Copy the full SHA 20721e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 725eeb1 - Browse repository at this point
Copy the full SHA 725eeb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1dfee78 - Browse repository at this point
Copy the full SHA 1dfee78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fe792f - Browse repository at this point
Copy the full SHA 9fe792fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c335b1e - Browse repository at this point
Copy the full SHA c335b1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a15708a - Browse repository at this point
Copy the full SHA a15708aView commit details
Commits on Nov 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ff3d971 - Browse repository at this point
Copy the full SHA ff3d971View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22a2572 - Browse repository at this point
Copy the full SHA 22a2572View commit details -
Configuration menu - View commit details
-
Copy full SHA for 904bc29 - Browse repository at this point
Copy the full SHA 904bc29View commit details -
Configuration menu - View commit details
-
Copy full SHA for f016fbc - Browse repository at this point
Copy the full SHA f016fbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f40b4c - Browse repository at this point
Copy the full SHA 0f40b4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 313a901 - Browse repository at this point
Copy the full SHA 313a901View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f9168a - Browse repository at this point
Copy the full SHA 1f9168aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a40358 - Browse repository at this point
Copy the full SHA 1a40358View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95add43 - Browse repository at this point
Copy the full SHA 95add43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6da2636 - Browse repository at this point
Copy the full SHA 6da2636View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc995ef - Browse repository at this point
Copy the full SHA bc995efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 153a501 - Browse repository at this point
Copy the full SHA 153a501View commit details -
Configuration menu - View commit details
-
Copy full SHA for 796a100 - Browse repository at this point
Copy the full SHA 796a100View commit details -
Configuration menu - View commit details
-
Copy full SHA for 483f4b1 - Browse repository at this point
Copy the full SHA 483f4b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d7b44c - Browse repository at this point
Copy the full SHA 3d7b44cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd12b99 - Browse repository at this point
Copy the full SHA bd12b99View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2d57f9 - Browse repository at this point
Copy the full SHA f2d57f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf7897b - Browse repository at this point
Copy the full SHA cf7897bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b430cb4 - Browse repository at this point
Copy the full SHA b430cb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bae44a7 - Browse repository at this point
Copy the full SHA bae44a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60daaa3 - Browse repository at this point
Copy the full SHA 60daaa3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04397fe - Browse repository at this point
Copy the full SHA 04397feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 206eb19 - Browse repository at this point
Copy the full SHA 206eb19View commit details