-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the superscript and subscript tags #407
Conversation
Support the superscript and subscript tags
Thanks for the fix, could you please add some tests? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 97.23% 97.26% +0.02%
==========================================
Files 11 11
Lines 1120 1132 +12
==========================================
+ Hits 1089 1101 +12
Misses 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'd suggest and highly recommend to keep the default output of html2text close to plain-text as possible while being compatible with HTML.
While supporting superscript and subscript is a very nice addition, considering above, it would be much better to have the feature as a flag. (worth noting, many markdown parsers or renderers don't happen to have such support ) For instance flag If we can have such flexibility in this, we can have this merged and include in the next release. |
CI failed to pass the tests. As the default behavior has sup/sub tags ignored, the way of having test (html->md files) won't work since the test runner will run the HTML2Text with default configuration. The test need to be changed to a python file like how it's done for |
… "--no-ignore-sup-sub"
Thanks for the great contribution. |
Update init.py to support the superscript and subscript tags