[ZDC] bug fix and plot addition #2484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-zugravel
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
Barthelemy
approved these changes
Dec 9, 2024
Barthelemy
reviewed
Dec 9, 2024
| if (ih < (int)fMatrixHistoCounts_a[mod][ch].size()) { | ||
| getObjectsManager()->startPublishing(fMatrixHistoCounts_a[mod][ch].at(ih).histo); | ||
| try { | ||
| getObjectsManager()->addMetadata(fMatrixHistoCounts_a[mod][ch].at(ih).histo->GetName(), fMatrixHistoCounts_a[mod][ch].at(ih).histo->GetName(), "34"); |
There was a problem hiding this comment.
It is the same code used in line 965.
We want to use the histograms of type COUTSA to generate a trending plot of the rate during a run.
The difference between COUTS and COUTSA is the the second want is zeroed at each cycle and thus provides an estimate of the instantaneous rate and not the average one.
stefan-zugravel
force-pushed
the
1pcut
branch
from
fd37aec to
2cfcfc2
Compare
|
Resolved the clang-format issue and updated the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> FIXED - bug that hard-coded two configuration parameter
-> ADDED - ADC and TDC plots with a cut
-> ADDED - centroid plot with cut
-> ADDED - axis label on SIGNAL plots
-> ADDED - rate histogram for trending plot