refactor MonitorObject and adding Copy capabilities #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barthelemy
reviewed
Oct 7, 2024
| @@ -141,6 +143,9 @@ class MonitorObject : public TObject | |||
| // tells Merger to create an object with data from the last cycle only on the side of the complete object | |||
| bool mCreateMovingWindow = false; | |||
|
|
|||
| void releaseObject(); | |||
| void cloneAndSetObject(const MonitorObject&); | |||
|
|
|||
| ClassDefOverride(MonitorObject, 12); | |||
There was a problem hiding this comment.
you must increase the class version otherwise ROOT can't do the schema evolution.
not super important now that we don't store MO in the QCDB but still...
|
the thing is that I need this PR for QC-1201. But I don't know how necessary that ticket is... probably not much for HI. So I am 100% fine to just wait after HI... |
justonedev1
force-pushed
the
refactor_MO
branch
from
d904a4d to
857e3f5
Compare
knopers8
approved these changes
Oct 29, 2024
justonedev1
force-pushed
the
refactor_MO
branch
from
857e3f5 to
c83da24
Compare
|
@ktf Can you please take a look at the reason why the build checks are failing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when working on QC-1201 and implementing Copy function/ctor/operator I found that Monitor Object is weirdly written, moreover there are possiblities, where the class can leak memory. So I refactored it a bit while adding Copy function, ctor and operator.