THRatio: fix again update of histograms with bin labels #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A direct copy of the axis objects from the numerator to the ratio histograms, that was introduced in a recent commit, breaks the preservation of the bin labels that are eventually set in the ratio histogram. The code in this commit replaces the copy with an explicit update of the number and limits of the bins, such that it works also if the numerator is filled with `TH1::kCanRebin` set, and therefore the axis range can change after the histogram creation.
aferrero2707
requested review from
Barthelemy,
knopers8 and
justonedev1
as code owners
|
@Barthelemy @knopers8 @justonedev1 this PR will be followed by another one with additional unit tests that will catch this kind of regressions, and hopefully much more. |
Barthelemy
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A direct copy of the axis objects from the numerator to the ratio histograms, that was introduced in a recent commit, breaks the preservation of the bin labels that are eventually set in the ratio histogram.
The code in this commit replaces the copy with an explicit update of the number and limits of the bins, such that it works also if the numerator is filled with
TH1::kCanRebinorTH1::SetCanExtend()set, and therefore the axis range can change after the histogram creation.