Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITS: memory improvements and new normalization #2203

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

iravasen
Copy link
Collaborator

@iravasen iravasen commented Mar 22, 2024

This PR reduces the memory footprint in async/sync operations:

  • TrackTask:
    • From TH1/2D to TH1/2F
    • Flag to ignore histogram with several bins (the biggest in the task which is not used in async)
  • Cluster task:
    • Improved flag to ignore 1296 (yes: 1296) histograms in async. They were not published but memory was allocated. They take less than a MB by making the calculation with the number of bins but I'm almost sure that when added into the framework they take more (still to evaluate).
    • Remove three 3D C-arrays used as counters

For cluster task I checked that the results produced are exactly the same as for the older cluster task.

cc @JianLIUhep @IsakovAD

@iravasen iravasen requested a review from IsakovAD as a code owner March 22, 2024 13:54
@IsakovAD
Copy link
Collaborator

All is good, but do you use mPublishMore?

@iravasen
Copy link
Collaborator Author

thanks! Yes I used it here for async: AliceO2Group/O2DPG#1549

…hes with cluster id 2047 which is an InvalidPattern
@iravasen
Copy link
Collaborator Author

@IsakovAD I fixed the bug with getClusterCoordinates in my latest commit. The issue was that we were not using that function in the right way. Now copying from the O2 I have implemented the correct solution which treats properly the clusterID 2047 which is exactly o2::itsmft::CompCluster::InvalidPatternID. Not sure why we never observed this crash with the full geometry but only with the light-weight one. The root cause is that with the previous code getXCOG with id 2047 was looking a vector with size 2046.

@iravasen
Copy link
Collaborator Author

ok I'm done

@iravasen iravasen merged commit ddb8573 into AliceO2Group:master Mar 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants