Skip to content

Commit

Permalink
ITS Track Check returns Null Quality by default (#2470)
Browse files Browse the repository at this point in the history
Initializing Quality result with 0 had an effect of producing a Quality without a name and with level 0, which is treated as "not worse than Good".
This does not seem like an intentional behaviour, so I am proposing to use the default Null Quality instead.
Precautions will be taken in the framework, so that it cannot be done anymore.
  • Loading branch information
knopers8 authored Nov 7, 2024
1 parent 4e14555 commit 1cda518
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Modules/ITS/src/ITSTrackCheck.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Quality ITSTrackCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
mEtaRatio = o2::quality_control_modules::common::getFromConfig<float>(mCustomParameters, "EtaRatio", mEtaRatio);
mPhiRatio = o2::quality_control_modules::common::getFromConfig<float>(mCustomParameters, "PhiRatio", mPhiRatio);

Quality result = 0;
Quality result;
Int_t id = 0;
std::map<std::string, std::shared_ptr<MonitorObject>>::iterator iter;
for (iter = moMap->begin(); iter != moMap->end(); ++iter) {
Expand Down

0 comments on commit 1cda518

Please sign in to comment.