Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PWGHF] Add the possibility to run MC Gen only for HF derived data #9357

Merged
merged 7 commits into from
Jan 22, 2025
Merged

[PWGHF] Add the possibility to run MC Gen only for HF derived data #9357

merged 7 commits into from
Jan 22, 2025
+353 −171

Conversation

nzardosh
Copy link
Collaborator

@nzardosh nzardosh commented Jan 16, 2025 •
edited
Loading

Adding the option to run MCGen Only workflows for derived data. Moving the MCGen part of the candidate creators to a common header which can be shared with the derived data, ensuring there is never a discrepancy
@fgrosa @vkucera

@nzardosh nzardosh marked this pull request as draft January 16, 2025 16:12
@github-actions github-actions bot added the pwghf PWG-HF label Jan 16, 2025
@github-actions github-actions bot changed the title Adding the possibility to run MCGen only for HF derived data [PWGHF] Adding the possibility to run MCGen only for HF derived data Jan 16, 2025
vkucera
vkucera reviewed Jan 16, 2025
View reviewed changes
PWGHF/Core/HfMcGenHelper.h Outdated Show resolved Hide resolved
PWGHF/Core/HfMcGenHelper.h Outdated Show resolved Hide resolved
PWGHF/Core/HfMcGenHelper.h Outdated Show resolved Hide resolved
PWGHF/Core/HfMcGenHelper.h Outdated Show resolved Hide resolved
PWGHF/TableProducer/CMakeLists.txt Outdated Show resolved Hide resolved
PWGHF/TableProducer/candidateCreatorMcGenOnly.cxx Outdated Show resolved Hide resolved
PWGHF/TableProducer/candidateCreatorMcGenOnly.cxx Outdated Show resolved Hide resolved
PWGHF/TableProducer/candidateCreatorMcGenOnly.cxx Outdated Show resolved Hide resolved
PWGHF/TableProducer/candidateCreatorMcGenOnly.cxx Outdated Show resolved Hide resolved
PWGHF/TableProducer/derivedDataCreatorBplusToD0Pi.cxx Outdated Show resolved Hide resolved
@vkucera
Copy link
Collaborator

vkucera commented Jan 17, 2025 •
edited
Loading

Please address the O2 linter warnings relevant to your code.

vkucera
vkucera requested changes Jan 20, 2025
View reviewed changes
PWGHF/TableProducer/CMakeLists.txt Outdated Show resolved Hide resolved
PWGHF/TableProducer/derivedDataCreatorBplusToD0Pi.cxx Outdated Show resolved Hide resolved
PWGHF/Utils/utilsMcGen.h Outdated Show resolved Hide resolved
PWGHF/Utils/utilsMcGen.h Outdated Show resolved Hide resolved
PWGHF/Utils/utilsMcGen.h Show resolved Hide resolved
PWGHF/Utils/utilsMcGen.h Outdated Show resolved Hide resolved
@nzardosh nzardosh marked this pull request as ready for review January 22, 2025 13:04
@vkucera vkucera changed the title [PWGHF] Adding the possibility to run MCGen only for HF derived data [PWGHF] Add the possibility to run MC Gen only for HF derived data Jan 22, 2025
@vkucera vkucera enabled auto-merge (squash) January 22, 2025 13:30
@ktf ktf disabled auto-merge January 22, 2025 21:29
@ktf ktf merged commit ddbcbba into AliceO2Group:master Jan 22, 2025
13 of 15 checks passed
@ktf
Copy link
Member

ktf commented Jan 22, 2025

Please fix the linter in a subsequent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkucera vkucera vkucera approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner

@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner

@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner

@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner

@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner

@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner

@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner

@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner

@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner

Assignees
No one assigned
Labels
pwghf PWG-HF
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nzardosh @vkucera @ktf