-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWGHF] Extend information of sparses for efficiency evaluation. Refactor analysis utilities. #9153
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
e1d313c
added occ, cent and info on B had mother for FD candidates to sparses
Marcellocosti 83e2995
extended sparses for mc gen
Marcellocosti 9b2fe9f
fix axes for prompt
Marcellocosti 1444ce8
Please consider the following formatting changes
alibuild a14b192
[WIP] factorize occupancy functions
Marcellocosti b35e55c
removed code duplication
Marcellocosti 9523a44
removed old functions
Marcellocosti c1b48c2
deleted comments
Marcellocosti b76b7a7
removed redundant namespaces
Marcellocosti d1072f4
fixed spaces
Marcellocosti 07c80cb
Please consider the following formatting changes
alibuild eb2ef25
Merge pull request #6 from alibuild/alibot-cleanup-9153
Marcellocosti fa54966
Implemented Fabrizio's comment
Marcellocosti 27f48a3
Implement Vit's comments
Marcellocosti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The most common use-case of this function is when the
centEstimator
argument is aConfigurable<int>
type defined in the user tasks. As far as I am aware, casting is not defined fromConfigurable<int>
types toenum
types, so I don't know how to implement this conversion. Do you have any suggestion?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
centEstimator.value
as argument of callinggetCentralityColl
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understood correctly,
centEstimator
is aConfigurable<int>
type,centEstimator.value
extracts anint
value. But then I manage to get a working version only by passing to the functionstatic_cast<o2::hf_centrality::CentralityEstimator>(centEstimator.value)
since the casting from theint
to anenum
type is not automatic.