[PWGJE] detailed QA for ch-jet spectra in pp #9133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonsukbae
requested review from
alibuild,
maoyx,
nzardosh,
fjonasALICE,
mfasDa and
mhemmer-cern
as code owners
github-actions
bot
changed the title
|
Since only 1 histogram is being filled here i think it does not warrant an extra task. Could you please make the PR in the normal QA task instead? |
|
Hi @joonsukbae , What is the status of this PR? Will you move to the QA task or extend this task in the future with further histograms? Should this PR stay open or should it be closed? |
|
Hi Florian, sorry for not to response, debugging took more than expected. I'm going to make a new PR with many more updates including perpendicular cone method subtraction. Thank you for reminding me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
independent further tasks to avoid too much consumption on memory and CPU for core QA task