Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to save multiple MFT-MUON matching candidates #1872

Closed
wants to merge 1 commit into from
Closed

Adding option to save multiple MFT-MUON matching candidates #1872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions MC/bin/o2dpg_sim_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ def add(cfg, flatconfig):
add(config, {"FwdMatching.matchFcn" : "matchsXYPhiTanl"})
if args.fwdmatching_cut_4_param == True:
add(config, {"FwdMatching.cutFcn" : "cut3SigmaXYAngles"})
if int(args.fwdmatchingNcandidates) > 0:
add(config, {"FwdMatching.saveMode" : 3})
add(config, {"FwdMatching.nCandidates" : int(args.fwdmatchingNcandidates)})

# deal with larger combinatorics
if args.col == "PbPb" or (args.embedding and args.colBkg == "PbPb"):
Expand Down
1 change: 1 addition & 0 deletions MC/bin/o2dpg_sim_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@

# Matching training for machine learning
parser.add_argument('--fwdmatching-save-trainingdata', action='store_true', help='enables saving parameters at plane for matching training with machine learning')
parser.add_argument('--fwdmatchingNcandidates', type=int, help='enables saving provided number of matching candidates', default=0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change is no longer necessary with #1869

You can now simply pass configurables from an external file. Could you please check if this works for you?

I really would favour to avoid adding more and more detector specific options to o2dpg_sim_workflow (when they merely set a config-key).


args = parser.parse_args()
print (args)
Expand Down
Loading