Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITS::tracking: stop fatalising job, drop TF instead #1848

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

mconcas
Copy link
Collaborator

@mconcas mconcas commented Dec 12, 2024

Change the default behaviour, provided AliceO2Group/AliceO2#13791 is included.
We stop breaking the processing if too much memory is required, we cleanup and move to the next TF.
@shahor02 @chiarazampolli @alcaliva

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@shahor02
Copy link
Collaborator

Thanks @mconcas.

For @chiarazampolli and @alcaliva : Matteo sees that the reconstruction with ITS per-ROF mode (instead of per-Vertex mode used in PbPb23 causing some inefficiencies) may crash due to the high memory if there are 2 central collisions in the same ROF.
This is a protection to skip the TF if the combinatorics grows too high.
We should use this option if we go to per-ROF ITS processing.

@chiarazampolli
Copy link
Collaborator

Hello @shahor02 ,
If this is only when Per-PV is not enabled, should we have an if?
Chiara

@mconcas
Copy link
Collaborator Author

mconcas commented Dec 13, 2024

Hello @shahor02 , If this is only when Per-PV is not enabled, should we have an if? Chiara

This is regardless the per-PV, we see that there are anyways crashes even with the perPV, much less but still.
So I would treat this as a default option for PbPb in general. Not to be backported, as it affects only the % of success and not directly the physics.

@chiarazampolli chiarazampolli merged commit d7f2510 into master Dec 13, 2024
13 checks passed
@chiarazampolli chiarazampolli deleted the mconcas-patch-2 branch December 13, 2024 09:22
@chiarazampolli
Copy link
Collaborator

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants