-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to set the input specs for GLO QC dynamically, for K0s #1834
Possibility to set the input specs for GLO QC dynamically, for K0s #1834
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
@chiarazampolli why not putting the
to the |
Hello @shahor02 , I guess I have to, or it will not work (the CI fails). Another way is to switch off the K0s QC in the JSON for sync. For now, I am moving this PR to WIP. Chiara |
40340cc
to
072f901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, assuming that the jq
manipulations are correct, I am not familiar with this.
BTW, EPNSYNCMODE
implies SYNCMODE
, it is enough to check the latter.
Hello @shahor02 , Comparing lines 61 and 147 (where there are an "if"... "elif") it seems they are different. That is why we did like this. Should I remove Chiara |
|
Checkes passed, merging. |
@shahor02 @f3sch
It was tested in the FST enabling the sec vtx:
During the FST, there were issues with MFTdigits (when saving the QC output to file via the
--local-batch=QC.root
option) and also the TOF raw QC (which was then disabled).For the FST, to enable sec vtx, I set:
WORKFLOW_EXTRA_PROCESSING_STEPS=...MATCH_SECVTX,MATCH_TPCTOF
where
MATCH_TPCTOF
can also be omitted. This sameWORKFLOW_EXTRA_PROCESSING_STEPS=...MATCH_SECVTX
would then be needed in online.Note that the reco_ASYNC in the FST also needs a change in the fst script, see AliceO2Group/AliceO2#13770, since we need strangeness tracking in ASYNC for the AODs (disabled above by
export ARGS_EXTRA_PROCESS_o2_secondary_vertexing_workflow='--disable-cascade-finder --disable-3body-finder --disable-strangeness-tracker'
)async reco was then tested on one run from zzo.