Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MCH aQC for MC #1830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lmassacr
Copy link
Contributor

@lmassacr lmassacr commented Dec 4, 2024

Adding to DPG scripts the workflows for the aQC of MCH and MCH+MID objects

Copy link

github-actions bot commented Dec 4, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@chiarazampolli
Copy link
Collaborator

Hello @JianLIUhep , @aferrero2707

Can you check this one?

Chiara

@JianLIUhep
Copy link
Contributor

Hi @lmassacr, is MC/config/QC/json/mftmchmid-tracks-task.json needed? I do not see it is included in any workflow you introduced in this PR.

@lmassacr
Copy link
Contributor Author

Hi @JianLIUhep,

Indeed I anticipated a next PR to come by putting already the json file. I still need indeed to add the workflow for MCH+MFT and MCH+MFT+MID tracks for the MC aQC. The corresponding modifications of the dpg scripts is work in progress. My local tests are currently failing.

Regarding this PR, I see that I have an error in the automatic checks (which I didn't get locally). This is related to the fact the the QC reads some intermediate .root files produced by the muon reco, for which it seems the file is eitheir corrupted or an array was not properly filled.
I was wondering if this could be due to the fact that only few simulated events are produced by the test and the array is empty. I am not sure how to add a protection in the dpg script against this problem. This is actually not directly a feature of the QC code I commited.
@aferrero2707 do you have some suggestions?

Cheers,
Laure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants