Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protection against corrupt O2DPG repository during topology generation #1778

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

ehellbar
Copy link
Collaborator

I tested this locally both from scratch and with a corrupt repository from one of the topology generations today.

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@ehellbar
Copy link
Collaborator Author

@davidrohr I updated the commit as we discussed

  1. reset to HEAD from the start
  2. clean untracked files

Copy link
Collaborator

@davidrohr davidrohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!
Have you tested it on the corrupted repository that you have saved?

@ehellbar
Copy link
Collaborator Author

Yes, it works as expected

@davidrohr
Copy link
Collaborator

great, then let's get it merged, and let's ask RC to deploy with the next SW update, since we had 2 such failures already.

@sawenzel sawenzel merged commit 4fb7da4 into AliceO2Group:master Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants