Mother particle transport off #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3fea6832f32d9429c7249453e33a03c6c81a2.
mbroz84
requested review from
sawenzel,
chiarazampolli,
benedikt-voelkel and
a team
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
+async-label async-2023-pbpb-apass4 |
github-actions
bot
added
the
async-2023-pbpb-apass4
sawenzel
reviewed
Oct 9, 2024
| @@ -217,7 +217,7 @@ class GeneratorStarlight_class : public Generator | |||
| 0,0,0,0); | |||
| //particle.Print(); | |||
| mParticles.push_back(particle); | |||
| o2::mcutils::MCGenHelper::encodeParticleStatusAndTracking(mParticles.back(), 11); | |||
| o2::mcutils::MCGenHelper::encodeParticleStatusAndTracking(mParticles.back(), 0); | |||
There was a problem hiding this comment.
For clarity it might actually be better to use "false/true" because the API specifies this as a boolean. (The value 11 from before is indeed misleading).
sawenzel
approved these changes
Oct 9, 2024
alcaliva
pushed a commit
that referenced
this pull request
Nov 2, 2024
* Bug fix, Mother particle transport (cherry picked from commit 390ee70)
alcaliva
removed
the
async-2023-pbpb-apass4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for transport of mother particle.