Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology parser: Override stdin file descriptor of the scripts that are called with an empty one #1747

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

davidrohr
Copy link
Collaborator

This fixes the topology generation failures which we started to see today.
No idea why it never happened before, and why now many environments are affected.

What happens is that stdin is passed from the script called by ODC to the topology parser and then to the DPL executables, and apparently in some cased we get an stdin file descriptor which reports to be not empty, but reading from it fails with bad file descriptor. This fix just overrides the stdin for all the scripts called by the parser with an empty one.

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@davidrohr davidrohr merged commit ff7f885 into AliceO2Group:master Sep 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant