PWGHF: remove obsolete generator to avoid confusion

[fgrosa]

No description provided.

[github-actions]

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

[stefanopolitano]

Hi @fgrosa ! Thanks for the PR. For me, it is fine to remove this generator since it's quite old and I don't think it is used anymore. However, I would suggest removing the .ini file which points to it (https://github.com/AliceO2Group/O2DPG/blob/master/MC/config/PWGHF/ini/GeneratorHF.ini) and the .sh example for embedded simulations (https://github.com/AliceO2Group/O2DPG/blob/master/MC/run/PWGHF/run_embedding.sh) that points to the .ini file, as well.

[fgrosa]

Hi @fgrosa ! Thanks for the PR. For me, it is fine to remove this generator since it's quite old and I don't think it is used anymore. However, I would suggest removing the .ini file which points to it (https://github.com/AliceO2Group/O2DPG/blob/master/MC/config/PWGHF/ini/GeneratorHF.ini) and the .sh example for embedded simulations (https://github.com/AliceO2Group/O2DPG/blob/master/MC/run/PWGHF/run_embedding.sh) that points to the .ini file, as well.

Good point @stefanopolitano! I removed another bunch of obsolete files on top of what you suggested.

[fgrosa]

Hi @lucamicheletti93 @ffionda @crisjahnke we noticed that the generator https://github.com/AliceO2Group/O2DPG/blob/master/MC/config/PWGHF/external/generator/GeneratorHF.C that I am removing is used in DQ (https://github.com/AliceO2Group/O2DPG/blob/master/MC/config/PWGDQ/external/generator/GeneratorCharmToMu_EvtGen.C). Please note that this is obsolete, and, in case you need a generator for Pb-Pb from HF you should use this one https://github.com/AliceO2Group/O2DPG/blob/master/MC/config/PWGHF/external/generator/generator_pythia8_embed_hf.C. We will anyway don't merge this PR until you confirm us that it's good for you!

[lucamicheletti93]

@fgrosa thanks a lot! I checked with @ffionda and we confirm that it is fine for us. We are not really using it, and in case we will upgrade to the new one.

[stefanopolitano]

Hi @lucamicheletti93 ! Thanks for the update, I don't have any further comment. Approved!

[alcaliva]

this PR is now included in the tag for the Pb-Pb apass4 that is being built. Label removed

[sawenzel]

I noticed that some other groups PWGDQ/PWGEM used GeneratorHF.C within their setups.
For instance here:

MC/config/PWGDQ/external/generator/GeneratorBeautyToJpsi_EvtGen.C:#include "GeneratorHF.C"
MC/config/PWGDQ/external/generator/GeneratorBeautyToMu_EvtGen.C:#include "GeneratorHF.C"
MC/config/PWGDQ/external/generator/GeneratorBeautyToPsiAndJpsi_EvtGen.C:#include "GeneratorHF.C"
MC/config/PWGDQ/external/generator/GeneratorBeautyToPsi_EvtGen.C:#include "GeneratorHF.C"
MC/config/PWGDQ/external/generator/GeneratorBplusToJpsiKaon_EvtGen.C:#include "GeneratorHF.C"
MC/config/PWGDQ/external/generator/GeneratorCharmToMu_EvtGen.C:#include "GeneratorHF.C"
MC/config/PWGEM/external/generator/GeneratorBeautyToEle_EvtGen.C:#include "GeneratorHF.C"
MC/config/PWGEM/external/generator/GeneratorCharmToEle_EvtGen.C:#include "GeneratorHF.C"

After this PR, these generators do no longer find GeneratorHF.C

Could
@AliceO2Group/reviewers-pwg-dq @AliceO2Group/reviewers-pwg-em please take a look?

[dsekihat]

From PWG-EM, it is OK to remove them. But, I would ask @rbailhac to comment, as she implemented the 2 files under EM.

[lucamicheletti93]

Dear @sawenzel , from DQ side it is fine to remove the obsolete generators!

[sawenzel]

@lucamicheletti93 , ok but DQ still references these files in their own setups. So some follow-up cleanup needs to be done on the side of DQ.

[chiarazampolli]

Not needed in cpass0, but it went to the tag.