Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding eta cuts to the trigger #1700

Merged
merged 11 commits into from
Aug 8, 2024
Merged

Adding eta cuts to the trigger #1700

merged 11 commits into from
Aug 8, 2024

Conversation

mbroz84
Copy link
Contributor

@mbroz84 mbroz84 commented Jul 14, 2024

Eta cuts in the trigger to have all daughter particles in the acceptance of muon or cent barrel.

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@mbroz84
Copy link
Contributor Author

mbroz84 commented Jul 24, 2024

The tests are failing due to
4987-G__O2MathUtils dictionary forward declarations' payload:19:41: note: previous definition is here
4988-namespace o2{namespace math_utils{using Rotation2Df_t = Rotation2D<float>;}}

Doesn't seem to have something with this PR.

@sawenzel
Copy link
Contributor

sawenzel commented Aug 8, 2024

Tested locally. Appears to be fine. Merging.

@sawenzel sawenzel merged commit 99e5525 into AliceO2Group:master Aug 8, 2024
6 of 7 checks passed
@mbroz84
Copy link
Contributor Author

mbroz84 commented Sep 2, 2024

+async-label async-2023-pbpb-apass4

@github-actions github-actions bot added the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label Sep 2, 2024
chiarazampolli pushed a commit that referenced this pull request Sep 6, 2024
* PWGUD Starlight interface
* Generator tests
* Adjusting links
* Eta cuts in trigger
* Skip photons

(cherry picked from commit 99e5525)
@chiarazampolli chiarazampolli removed the async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 label Sep 6, 2024
@chiarazampolli
Copy link
Collaborator

Ported to async-v1-01-18, label removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants