Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skimming needs to know NHBPERTF, extract from ALIEN_JDL_LPMRUNNUMBER #1680

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

shahor02
Copy link
Collaborator

@chiarazampolli @mpuccio the TFs with no data in the skimmed CTFs corresponded to TFs for which nothing was selected but the following 3TFs had something selected. The reason is that we did not set from the command line the NHBFPERTF (via HBFUTILS), as a result, the workflow was taking default 128 HBF. So, the ctf-reader was seeing something selected for the [1st_orbit : 1st_orbit+128] but detector encoders did not find any selected BC overlapping with the TF being processed and were writing empty CTF. Effectively, the --skip-skimmed-out-tf was not working for most of TFs, but this should be fully transparent for further processing.
The corruption reports is something else, still debugging.

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@chiarazampolli
Copy link
Collaborator

Thanks @shahor02 , do we need some further review, or should I merge?
To be understood how 2023 worked, since it is also with 128 orbits per TF.

@shahor02
Copy link
Collaborator Author

@chiarazampolli all 2023 has the same problem: many TFs rejected by the trigger are stored with 0 data, but this does not pose any problem (except ~1% increase of the new CTF size).

@shahor02 shahor02 merged commit 8279d4b into AliceO2Group:master Jun 28, 2024
6 of 7 checks passed
@shahor02 shahor02 added async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 labels Jul 17, 2024
@alcaliva alcaliva removed async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2024-pp-cpass0 Request porting to async-2024-pp-cpass0 labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants