-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFT: new configuration check for async qc #1679
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Hi @chiarazampolli, I have added new check for async qc for MFT, could you please push it to checks? It is my first PR to this repository, so they are not automatic yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok to me, @JianLIUhep
Hello @ktf , What is the wf that needs special approval? I will approve it, but first I would like to know what this is about, it is something new... Cheers, |
The code is good to me as well. |
Hi @chiarazampolli, @JianLIUhep, the PR didn't merge due to errors in the checks, however I don't think they are related to my code. Can you please take a look at it and, if all is alright, merge it? |
Hello @Edingrast , Yes, the errors are unrelated. I am pinging again @ktf , and adding @singiamtel since I don't understand the message in the PR about which I asked here: #1679 (comment) Chiara |
Hi @chiarazampolli ,
I believe our workflows need approval if they're not opened by an org member (https://github.com/orgs/AliceO2Group/people) or otherwise trusted member. Full list of requirements here: https://github.com/alisw/ali-bot/blob/master/list-branch-pr#L146 Cheers, |
Thanks @singiamtel ! Is it ok then to have this PR? @Edingrast , why are you not part of the ALICE organization? Chiara |
Hi @chiarazampolli, |
Hello @singiamtel , Chiara |
New MFT configuration check. New code already merged to QC (MFT: New configuration check in QC QualityControl#2357).
This is a changed configuration for async qc for proper timestamp retrieval.