Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFT: new configuration check for async qc #1679

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

Edingrast
Copy link
Contributor

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@Edingrast
Copy link
Contributor Author

Hi @chiarazampolli, I have added new check for async qc for MFT, could you please push it to checks? It is my first PR to this repository, so they are not automatic yet.

Copy link
Collaborator

@chiarazampolli chiarazampolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me, @JianLIUhep

@chiarazampolli
Copy link
Collaborator

Hello @ktf ,

What is the wf that needs special approval?

Screenshot 2024-06-28 at 15 09 05

I will approve it, but first I would like to know what this is about, it is something new...

Cheers,
Chiara

@JianLIUhep
Copy link
Contributor

The code is good to me as well.

@Edingrast
Copy link
Contributor Author

Hi @chiarazampolli, @JianLIUhep, the PR didn't merge due to errors in the checks, however I don't think they are related to my code. Can you please take a look at it and, if all is alright, merge it?

@chiarazampolli
Copy link
Collaborator

Hello @Edingrast ,

Yes, the errors are unrelated. I am pinging again @ktf , and adding @singiamtel since I don't understand the message in the PR about which I asked here: #1679 (comment)
I hope they can comment. Then I will merge.

Chiara

@singiamtel
Copy link
Collaborator

Hi @chiarazampolli ,

What is the wf that needs special approval?

I believe our workflows need approval if they're not opened by an org member (https://github.com/orgs/AliceO2Group/people) or otherwise trusted member.

Full list of requirements here: https://github.com/alisw/ali-bot/blob/master/list-branch-pr#L146

Cheers,
Sergio

@chiarazampolli
Copy link
Collaborator

Thanks @singiamtel ! Is it ok then to have this PR? @Edingrast , why are you not part of the ALICE organization?

Chiara

@Edingrast
Copy link
Contributor Author

Hi @chiarazampolli,
I am not sure what you mean by "not being part of the ALICE organization". I am working on ALICE and also on MFT, so I am part of collaboration. I am not listed in the list of org people. The workflow approval is usual when there is a PR from someone new. So far I have made PR in O2Physics and QC (first time there was special approval needed for the first time), after the first PR I was already a trusted member, since I had previous PR.

@chiarazampolli
Copy link
Collaborator

Hello @singiamtel ,
I am not so expert with the rules in github, I thought maybe you needed to be part of some egroup.
Anyway, now I approved. Since the remaining tests (blocked by this approval) ran fine, I am merging.

Chiara

@chiarazampolli chiarazampolli merged commit 1575edb into AliceO2Group:master Jul 8, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants