Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWGHF: fix PDG code of L(1520) in Lc decays. #1673

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

mfaggin
Copy link
Contributor

@mfaggin mfaggin commented Jun 21, 2024

@fcatalan92 @fgrosa @fcolamar @stefanopolitano @DelloStritto triggered by a couple of unexpected things in analysis, I started debugging a bit our MC productions and I found that apparently the PDG code of the Lambda(1520) is wrong in our PYTHIA configurations.

Apparently the correct PDG code is 102134 as listed in the manual https://pythia.org/latest-manual/Welcome.html >> Particles and Decays >> Particle Data , and not 3124 as written when adding and forcing the decay Lc --> Lambda(1520)pi. For some reasons, the correct PDG code was there already for the forcing of the Lambda(1520) --> pK.

Just as an example, I have tested it with the Pb-Pb generator MC/config/PWGHF/external/generator/generator_pythia8_embed_hf.C using the bash script here https://cernbox.cern.ch/s/BdlYlDpPXFRhZmy (10 generated events, w/o anchoring and w/o embedding), forcing all Lc hadrons to decay into the channel Lc --> Lambda(1520)pi (see thic config https://cernbox.cern.ch/s/WxM6pgRGcc2BSYT, which is https://github.com/AliceO2Group/O2DPG/blob/master/MC/config/PWGHF/pythia8/generator/pythia8_charmhadronic_with_decays_Mode2_hardQCD_5TeV.cfg just commenting out all other decays) and then I checked the content with this tester https://cernbox.cern.ch/s/82E7SFp01j3nU0m (which is exactly this one MC/config/PWGHF/ini/tests/GeneratorHF_D2H_ccbar_and_bbbar_PbPb.C a bit modified just to monitor this specific aspect).
Below a screenshot of one of my tests:

photo_2024-06-21_13-56-08

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

@fgrosa fgrosa added async-2023-pbpb-apass3 async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2022-pp-apass7 Request porting to async-2022-pp-apass7 labels Jun 21, 2024
Copy link
Contributor

@fcatalan92 fcatalan92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mfaggin, nice that you spotted this issue. From a quick grep I found another PWGHF file not yet fixed PWGHF/pythia8/decayer/force_hadronic_D.cfg, could you modify it too?
Moreover, the same issue affects configurations under PWGGAJE, PWGDQ, PWGEM, PWGLF. Maybe we should propagate this information to the relevant people.

@mfaggin
Copy link
Contributor Author

mfaggin commented Jun 21, 2024

thanks @fcatalan92 , I've fixed it also in the additional file that you found.
Concerning your second point, I would agree with you. What about writing a mail when this PR will be merged?

@fgrosa
Copy link
Contributor

fgrosa commented Jun 24, 2024

Hi @mfaggin @fcatalan92 thanks! Regarding force_hadronic_D.cfg, I think we should remove it because it is not used and might create confusion in the future. We can do it in another iteration though.

@fgrosa fgrosa merged commit 328c826 into AliceO2Group:master Jun 24, 2024
6 checks passed
@fcatalan92
Copy link
Contributor

@AliceO2Group/reviewers-pwg-je, @AliceO2Group/reviewers-pwg-dq, @AliceO2Group/reviewers-pwg-em, @AliceO2Group/reviewers-pwg-lf
Please note this fix for the PDG code of the Lambda(1520), the same problem is present in other configuration files for your PWGs

benedikt-voelkel pushed a commit that referenced this pull request Jun 26, 2024
* Fix PDG code of L(1520) in Lc decays.

* Fix L(1520) PDG code also in testers.

* Fix PDG code also in force_hadronic_D.cfg.

---------

Co-authored-by: Mattia Faggin <[email protected]>
(cherry picked from commit 328c826)
@benedikt-voelkel benedikt-voelkel removed async-2023-pbpb-apass4 Request porting to async-2023-pbpb-apass4 async-2023-pp-apass4 Request porting to async-2023-pp-apass4 async-2024-pp-apass1 Request porting to async-2024-pp-apass1 async-2022-pp-apass7 Request porting to async-2022-pp-apass7 labels Jun 26, 2024
benedikt-voelkel pushed a commit that referenced this pull request Jun 28, 2024
* Fix PDG code of L(1520) in Lc decays.

* Fix L(1520) PDG code also in testers.

* Fix PDG code also in force_hadronic_D.cfg.

---------

Co-authored-by: Mattia Faggin <[email protected]>
(cherry picked from commit 328c826)
@alcaliva alcaliva added the async-2022-pp-apass7 Request porting to async-2022-pp-apass7 label Aug 8, 2024
alcaliva pushed a commit that referenced this pull request Aug 8, 2024
* Fix PDG code of L(1520) in Lc decays.

* Fix L(1520) PDG code also in testers.

* Fix PDG code also in force_hadronic_D.cfg.

---------

Co-authored-by: Mattia Faggin <[email protected]>
(cherry picked from commit 328c826)
@alcaliva alcaliva removed the async-2022-pp-apass7 Request porting to async-2022-pp-apass7 label Aug 8, 2024
alcaliva pushed a commit that referenced this pull request Aug 23, 2024
* Fix PDG code of L(1520) in Lc decays.

* Fix L(1520) PDG code also in testers.

* Fix PDG code also in force_hadronic_D.cfg.

---------

Co-authored-by: Mattia Faggin <[email protected]>
(cherry picked from commit 328c826)
@fgrosa fgrosa added the async-2023-pp-apass4 Request porting to async-2023-pp-apass4 label Aug 23, 2024
@fgrosa
Copy link
Contributor

fgrosa commented Aug 23, 2024

label async-pp-2023-apass4 was removed by mistake, readding

@alcaliva alcaliva added async-2023-pp-apass4 Request porting to async-2023-pp-apass4 and removed async-2023-pp-apass4 Request porting to async-2023-pp-apass4 labels Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants