PWGHF: Pb-Pb generator to embed N HF events in a single underlying event. #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
@fcolamar @fcatalan92 @fgrosa @DelloStritto @stefanopolitano here what I was discussing with you before |
mfaggin
requested review from
sawenzel,
chiarazampolli,
benedikt-voelkel and
a team
as code owners
fgrosa
requested changes
Jun 14, 2024
There was a problem hiding this comment.
Ciao @mfaggin, many thanks for the work! I just have a two minor comments (mostly for the test, not really the generator itself)
Then I would like to ask you to remove this other generator https://github.com/AliceO2Group/O2DPG/blob/master/MC/config/PWGHF/external/generator/GeneratorHF.C, which is an outdated version of yours (to avoid confusion in the future). Thanks!
MC/config/PWGHF/external/generator/generator_pythia8_embed_hf.C
Outdated
Show resolved
Hide resolved
MC/config/PWGHF/ini/tests/GeneratorHF_D2H_ccbar_and_bbbar_PbPb.C
Outdated
Show resolved
Hide resolved
fgrosa
added
async-2023-pbpb-apass3
async-2023-pbpb-apass4
fgrosa
approved these changes
Jun 14, 2024
fgrosa
added
async-2022-pp-apass4
async-2023-pp-apass4
fgrosa
added
async-2023-pp-apass4-accepted
async-2024-pp-apass1
benedikt-voelkel
added
async-2022-pp-apass6-2023-PbPb-apass2
and removed
async-2022-pp-apass6-2023-PbPb-apass2
labels
benedikt-voelkel
pushed a commit
that referenced
this pull request
Jun 20, 2024
…ent. (#1666) * Pb-Pb generator to embed N HF events in a single underlying event. * Fix HF ev. generator creation. * fix * Fix particle stack filling and mother/daughter indixing. * Add .ini configuration file and tester, and hardQCD.cfg file. * Define mNumSigEvs depending on the collision impact parameter. * Fix o2sim_Kine path in test. * Add description. * Update author list of .cfg file. * Implement suggestions by fgrosa. * Function documentation. * Overriding generate event, to avoid simulating 1 untriggered event. --------- Co-authored-by: Mattia Faggin <[email protected]> (cherry picked from commit 36522d4)
benedikt-voelkel
removed
async-2023-pbpb-apass4
benedikt-voelkel
pushed a commit
that referenced
this pull request
Jun 21, 2024
…ent. (#1666) * Pb-Pb generator to embed N HF events in a single underlying event. * Fix HF ev. generator creation. * fix * Fix particle stack filling and mother/daughter indixing. * Add .ini configuration file and tester, and hardQCD.cfg file. * Define mNumSigEvs depending on the collision impact parameter. * Fix o2sim_Kine path in test. * Add description. * Update author list of .cfg file. * Implement suggestions by fgrosa. * Function documentation. * Overriding generate event, to avoid simulating 1 untriggered event. --------- Co-authored-by: Mattia Faggin <[email protected]> (cherry picked from commit 36522d4)
benedikt-voelkel
pushed a commit
that referenced
this pull request
Jun 25, 2024
…ent. (#1666) * Pb-Pb generator to embed N HF events in a single underlying event. * Fix HF ev. generator creation. * fix * Fix particle stack filling and mother/daughter indixing. * Add .ini configuration file and tester, and hardQCD.cfg file. * Define mNumSigEvs depending on the collision impact parameter. * Fix o2sim_Kine path in test. * Add description. * Update author list of .cfg file. * Implement suggestions by fgrosa. * Function documentation. * Overriding generate event, to avoid simulating 1 untriggered event. --------- Co-authored-by: Mattia Faggin <[email protected]> (cherry picked from commit 36522d4)
feisenhu
pushed a commit
to feisenhu/O2DPG
that referenced
this pull request
Jul 1, 2024
…ent. (AliceO2Group#1666) * Pb-Pb generator to embed N HF events in a single underlying event. * Fix HF ev. generator creation. * fix * Fix particle stack filling and mother/daughter indixing. * Add .ini configuration file and tester, and hardQCD.cfg file. * Define mNumSigEvs depending on the collision impact parameter. * Fix o2sim_Kine path in test. * Add description. * Update author list of .cfg file. * Implement suggestions by fgrosa. * Function documentation. * Overriding generate event, to avoid simulating 1 untriggered event. --------- Co-authored-by: Mattia Faggin <[email protected]>
alcaliva
pushed a commit
that referenced
this pull request
Aug 8, 2024
…ent. (#1666) * Pb-Pb generator to embed N HF events in a single underlying event. * Fix HF ev. generator creation. * fix * Fix particle stack filling and mother/daughter indixing. * Add .ini configuration file and tester, and hardQCD.cfg file. * Define mNumSigEvs depending on the collision impact parameter. * Fix o2sim_Kine path in test. * Add description. * Update author list of .cfg file. * Implement suggestions by fgrosa. * Function documentation. * Overriding generate event, to avoid simulating 1 untriggered event. --------- Co-authored-by: Mattia Faggin <[email protected]> (cherry picked from commit 36522d4)
alcaliva
pushed a commit
that referenced
this pull request
Aug 23, 2024
…ent. (#1666) * Pb-Pb generator to embed N HF events in a single underlying event. * Fix HF ev. generator creation. * fix * Fix particle stack filling and mother/daughter indixing. * Add .ini configuration file and tester, and hardQCD.cfg file. * Define mNumSigEvs depending on the collision impact parameter. * Fix o2sim_Kine path in test. * Add description. * Update author list of .cfg file. * Implement suggestions by fgrosa. * Function documentation. * Overriding generate event, to avoid simulating 1 untriggered event. --------- Co-authored-by: Mattia Faggin <[email protected]> (cherry picked from commit 36522d4)
|
label async-pp-2023-apass4 was removed by mistake, readding |
alcaliva
added
async-2023-pp-apass4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.