-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWGUD Starlight interface #1663
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
@mbroz84 : Interesting development. So you intend to use Starlight as a library and not in HepMC mode? We need to do the changes in alidist and to Starlight that you have already laied out. No way to use a static lib. I can take care of changes to Starlight + alidist but I would need a testing shell script on your side (an invocation of the generator using an actual ini file). This is anyways required to test your generator setup in the CI (@benedikt-voelkel can give more details). |
Hi, yes we want to STARlight as a library, its more practical and allow simple connection with EvtGen that we used also before in AliRoot. Concerning the script: you mean something like MC/run/PWG... ? |
Yes, something of the sort (before comitting, you could send me an example so that I have something to test) |
Attached is a script that creates the config and runs generator via o2-sim |
* build STARlight as a shared library * fix the installed header files, so that they can be included in ROOT macros without symbol shadowing (STARlight defines global C++ macro names such as `printInfo` which conflict with similar names in other packages) With this commit, it will be possible to use the STARlight system directly in event generation. See for instance: AliceO2Group/O2DPG#1663
* build STARlight as a shared library * fix the installed header files, so that they can be included in ROOT macros without symbol shadowing (STARlight defines global C++ macro names such as `printInfo` which conflict with similar names in other packages) With this commit, it will be possible to use the STARlight system directly in event generation. See for instance: AliceO2Group/O2DPG#1663
* build STARlight as a shared library * fix the installed header files, so that they can be included in ROOT macros without symbol shadowing (STARlight defines global C++ macro names such as `printInfo` which conflict with similar names in other packages) With this commit, it will be possible to use the STARlight system directly in event generation. See for instance: AliceO2Group/O2DPG#1663
In principle everything is prepared. I asked for PRs to STARlight + alidist as described in the ticket https://its.cern.ch/jira/browse/O2-5076. Let's hope the STARlight team reacts quickly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve to run CI
* build STARlight as a shared library * fix the installed header files, so that they can be included in ROOT macros without symbol shadowing (STARlight defines global C++ macro names such as `printInfo` which conflict with similar names in other packages) With this commit, it will be possible to use the STARlight system directly in event generation. See for instance: AliceO2Group/O2DPG#1663
Hello @mbroz84 In that way, the Let me know if you have further questions in that direction. Some documentation is here: https://aliceo2group.github.io/simulation/docs/generators/generatorconfig.html#generator-tests |
Hello @benedikt-voelkel I added two tests, one for STARlight alone and one for STARlight -> EvtGen |
I don't get it... How I'm supposed to load the STARlight library? Apparently none of the two |
We'll look into it. |
I tested locally and both with In the CI, the |
Works for me in the combination
|
For me locally (o2-sim environment) works only the second option (with full path) because in the LD_LIBRARY_PATH I see |
The issue should be fixed by alisw/alidist#5514. Please just use
It is better to avoid too many hard-coded paths |
+async-label async-2023-pbpb-apass4 |
* PWGUD Starlight interface (cherry picked from commit f79426f)
* build STARlight as a shared library * fix the installed header files, so that they can be included in ROOT macros without symbol shadowing (STARlight defines global C++ macro names such as `printInfo` which conflict with similar names in other packages) With this commit, it will be possible to use the STARlight system directly in event generation. See for instance: AliceO2Group/O2DPG#1663 (cherry picked from commit d2b3ebd)
Ported to async-v1-01-18, label removed. |
* build STARlight as a shared library * fix the installed header files, so that they can be included in ROOT macros without symbol shadowing (STARlight defines global C++ macro names such as `printInfo` which conflict with similar names in other packages) With this commit, it will be possible to use the STARlight system directly in event generation. See for instance: AliceO2Group/O2DPG#1663
Interface to STARlight generator that is used by UPC PAG. Some processes are eventually decayed by EvtGen that is interfaced in DQ, we use our own decay tables to avoid any conflict. Configuration .ini file is created by python script.
There are two issues that needs to be fixed before merging this PR:
Then in the alidist we would need to define $STARLIGHT_ROOT variable and add it to PATH and LD_LIBRARY_PATH.