Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support to treat events from HepMC event files (multi-timefram… #1654

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

sawenzel
Copy link
Contributor

…e case)

Some users give existing .hepmc files to the event generator.

So far, this was problematic because separate timeframes will read from the same file and due to a lack of synchronization, each timeframe read the same events.

This is now fixed. Whenever an hepmc event file is given as input to O2DPG-MC, we make sure that timeframes read from the HepMC file incrementally. This is achieved through:

  • sequentially producing events for timeframes
  • communication of the number processed from one timeframe to the next (via HepMCEventSkip.json file).

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted
async-2023-pp-apass4
async-2023-pp-apass4-accepted
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-pp-cpass0-accepted
async-2022-pp-apass7-accepted
async-2024-pp-apass1-accepted

…e case)

Some users give existing .hepmc files to the event generator.

So far, this was problematic because separate timeframes will
read from the same file and due to a lack of synchronization, each
timeframe read the same events.

This is now fixed. Whenever an hepmc event file is given
as input to O2DPG-MC, we make sure that timeframes read from the HepMC
file incrementally. This is achieved through:

- sequentially producing events for timeframes
- communication of the number processed from one timeframe to the next
  (via HepMCEventSkip.json file).
@sawenzel sawenzel force-pushed the swenzel/hepmcimprovment branch from 3e9b2b3 to 8ccb426 Compare May 31, 2024 13:24
@sawenzel sawenzel merged commit 74684c5 into AliceO2Group:master Jun 3, 2024
6 checks passed
@sawenzel sawenzel deleted the swenzel/hepmcimprovment branch June 3, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant