-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TPC: Update stochastic cluster and systematic track errors #1624
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
@shahor02 , looks ok to me, could you also take a look? |
Sorry for missing your ping, fine for me. I guess @wiechula have tested it already. I'll also run some reco with it locally. |
Ok, then I will wait for green light before merging. |
In my local test everything is propagated properly to the workflow. The final validation if not all parameters set as default are as we expect is still missing. But this is not related to this PR. |
Yes, checking results now, will finish soon |
@chiarazampolli , the tests were run, I'm still waiting for feedback from @miranov25 |
Well, some shortening of TPC tracks is expected with strict errors but to me it seems to be too strong, also the amount of short tracks increases significantly. Better @miranov25 comments if this agrees with his optimization. |
Hello, I then propose to merge and start. Let me know if you have anything against it. Chiara |
I would wait for response from @miranov25 |
Hello @miranov25 , Please comment the plots above: I assume top is with the new cl error param, e bottom without, right? I am now merging to move to test mode. Chiara |
Hello. |
Hello @shahor02, Regarding your statement about the K0s and chi2 cut, I understand your points and agree with them. However, as we discussed over the past weeks, and especially last Wednesday, the TPC-ITS matching should be modified. I will attempt to implement a better TPC-ITS matching strategy utilizing max likelihood, taking background into account, and using checking causality for shorter TPC track (allowing them) .... Marian |
I think we should try to understand why the tracks fail to use lower pad-rows and try to recover them. David provided me with the settings which can affect tracking at lower pad-rows, but it will take time to test this. |
(cherry picked from commit 721e4c7)
No description provided.