Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove option ctp-readout-create #1607

Merged
merged 1 commit into from
May 22, 2024

Conversation

mfasDa
Copy link
Contributor

@mfasDa mfasDa commented Apr 24, 2024

  • ctp readout create does not properly work in
    2023 as only 1 trigger class per trigger is
    expeected
  • By design it is impossible to recover the trigger
    classes from the trigger records as they are not
    encoded in the trigger record, so the min. bias trigger
    is assumed. This does not work for triggers that
    provide triggers themselves.

- ctp readout create does not properly work in
  2023 as only 1 trigger class per trigger is
  expeected
- By design it is impossible to recover the trigger
  classes from the trigger records as they are not
  encoded in the trigger record, so the min. bias trigger
  is assumed. This does not work for triggers that
  provide triggers themselves.
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted

@mfasDa
Copy link
Contributor Author

mfasDa commented Apr 24, 2024

+async-label async-2023-pbpb-apass3, async-2023-pbpb-apass4, async-2022-pp-apass6-2023-PbPb-apass2, async-2022-pp-apass4-accepted, async-2023-pbpb-apass3-accepted, async-2023-pbpb-apass4-accepted, !async-2022-pp-apass6-2023-PbPb-apass2, !async-2022-pp-apass4-accepted, !async-2022-pp-apass6-2023-PbPb-apass2-accepted

@benedikt-voelkel
Copy link
Contributor

Thanks for the labels @mfasDa . I just removed the accepted ones.
They will be added once that is actually in. Adding those will actually not be possible in the very near future ;)

Could you just check once more if your labels are correct now?

@chiarazampolli
Copy link
Collaborator

Hello @mfasDa ,
I thought we discussed to first ask TRD, HMP, PHS, CPV, did I misunderstand?
Chiara

@mfasDa mfasDa changed the title Remove option ctp-readout-create [WIP] Remove option ctp-readout-create Apr 24, 2024
@mfasDa
Copy link
Contributor Author

mfasDa commented Apr 24, 2024

@chiarazampolli I have opened the PR for review from the other triggered detectors. I added a WIP label to prevent merging.

@chiarazampolli
Copy link
Collaborator

Great, thanks!!
Chiara

@mfasDa mfasDa changed the title [WIP] Remove option ctp-readout-create Remove option ctp-readout-create May 15, 2024
@chiarazampolli
Copy link
Collaborator

Merging.
I guess we should add also 2024 labels, right, @mfasDa ?

@chiarazampolli
Copy link
Collaborator

Wait, before merging, I will let the CI run.

@mfasDa
Copy link
Contributor Author

mfasDa commented May 15, 2024

Right, we need it also for the MCs anchored to 2024.

@chiarazampolli chiarazampolli merged commit 6b4452c into AliceO2Group:master May 22, 2024
7 checks passed
benedikt-voelkel pushed a commit that referenced this pull request May 23, 2024
- ctp readout create does not properly work in
  2023 as only 1 trigger class per trigger is
  expeected
- By design it is impossible to recover the trigger
  classes from the trigger records as they are not
  encoded in the trigger record, so the min. bias trigger
  is assumed. This does not work for triggers that
  provide triggers themselves.

(cherry picked from commit 6b4452c)
benedikt-voelkel pushed a commit that referenced this pull request May 23, 2024
- ctp readout create does not properly work in
  2023 as only 1 trigger class per trigger is
  expeected
- By design it is impossible to recover the trigger
  classes from the trigger records as they are not
  encoded in the trigger record, so the min. bias trigger
  is assumed. This does not work for triggers that
  provide triggers themselves.

(cherry picked from commit 6b4452c)
benedikt-voelkel pushed a commit that referenced this pull request May 28, 2024
- ctp readout create does not properly work in
  2023 as only 1 trigger class per trigger is
  expeected
- By design it is impossible to recover the trigger
  classes from the trigger records as they are not
  encoded in the trigger record, so the min. bias trigger
  is assumed. This does not work for triggers that
  provide triggers themselves.

(cherry picked from commit 6b4452c)
feisenhu pushed a commit to feisenhu/O2DPG that referenced this pull request Jul 1, 2024
- ctp readout create does not properly work in
  2023 as only 1 trigger class per trigger is
  expeected
- By design it is impossible to recover the trigger
  classes from the trigger records as they are not
  encoded in the trigger record, so the min. bias trigger
  is assumed. This does not work for triggers that
  provide triggers themselves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants