Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen_topo.sh: Use /var/tmp/gen_topo as gen_topo temp folder #1606

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

davidrohr
Copy link
Collaborator

@martenole : Could we deploy this with the next software update?

It moves the gen_topo temp folder to a local folder on the infra node.
Not sure if you'll need to adapt any of your fetch/check scripts.

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2022-pp-apass6-2023-PbPb-apass2
async-2022-pp-apass4-accepted
async-2022-pp-apass6-2023-PbPb-apass2-accepted
async-2023-pbpb-apass3-accepted
async-2023-pbpb-apass4-accepted

Copy link
Collaborator

@martenole martenole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will include a new GenTopo for the next sw update. The log fetcher only queries /var/log/topology/gen-topo.log, so I don't have to change anything there

@martenole martenole merged commit 7b3f445 into AliceO2Group:master Apr 25, 2024
7 checks passed
@davidrohr
Copy link
Collaborator Author

@martenole : I think this was not yet deployed at P2? Will you check, or shall I follow up with Christian?

@martenole
Copy link
Collaborator

Ah, I think I have missed this, sorry. Will check today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants