Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MC/config for ALICE3 otf simulations #1595

Merged
merged 8 commits into from
Apr 16, 2024

Conversation

jesgum
Copy link
Contributor

@jesgum jesgum commented Apr 12, 2024

This pull request adds the MC/config/ALICE3 directory to be used for on-the-fly simulations on hyperloop.
Contains config and ini files for different beams. Is currently being tested and will be marked ready very shortly. Input is already welcome now, thanks!

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass
async-2023-pp-apass1
async-data
async-mc
async-2022-pp-apass6-2023-PbPb-apass2

@ddobrigk
Copy link
Collaborator

@benedikt-voelkel @sawenzel this is to be used with the OTF simulations on hyperloop: we'd need the ini files to be with an O2DPG tag. Can you please take a look and if ok carry on? Many many thanks! tagging also: @mconcas @jgrosseo

@sawenzel
Copy link
Contributor

Fine by me. Maybe we could just add a README.md in the MC/config/ALICE3 saying that these configs are used in Hyperloop studies, etc?

@ddobrigk
Copy link
Collaborator

Yes that's very reasonable. @jesgum can you please take care of that? Thank you!

@jesgum
Copy link
Contributor Author

jesgum commented Apr 15, 2024

It has now been added to the directory.

@sawenzel
Copy link
Contributor

Good. I think now you need remove the draft status.

@jesgum jesgum marked this pull request as ready for review April 15, 2024 09:57
@benedikt-voelkel
Copy link
Contributor

For this use case it would be fine to have dummy tests for the specific generators for now.
In any case, one basic test is anyway ran over the kinematics.

What is your opinion on that @sawenzel ?

@sawenzel
Copy link
Contributor

A CI test would be a "nice to have". But since this is ALICE3 R&D, it is probably not obligatory for now.

@ddobrigk
Copy link
Collaborator

Hi @sawenzel @benedikt-voelkel indeed, this is solely for ALICE 3 R&D and the use case does not cover regular simulations. I told @jesgum we could try with these empty external generator declarations, and that seems to have resolved the actual error message... but there is still an error marked - though the log itself says "No error found"? Not sure how to proceed... can you help us out? Thanks a lot!

@benedikt-voelkel benedikt-voelkel merged commit 7895aaa into AliceO2Group:master Apr 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants