[SimWF] Protect the -e argument #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, passing -embedding would work and produce a workflow.json. However, the resulting WF has nothing to with embedding, since the real flag for that has 2 dashed: --embedding What really happened was that the engine would now be "mbedding" So far there are no clashes for -j or -o which are also valid arguments.
benedikt-voelkel
requested review from
sawenzel and
chiarazampolli
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
benedikt-voelkel
added
async-2022-pp-apass4
async-2023-pbpb-apass4
benedikt-voelkel
added a commit
that referenced
this pull request
Apr 26, 2024
Without this, passing -embedding would work and produce a workflow.json. However, the resulting WF has nothing to with embedding, since the real flag for that has 2 dashed: --embedding What really happened was that the engine would now be "mbedding" So far there are no clashes for -j or -o which are also valid arguments. Co-authored-by: Benedikt Volkel <[email protected]>
benedikt-voelkel
added a commit
that referenced
this pull request
Apr 26, 2024
Without this, passing -embedding would work and produce a workflow.json. However, the resulting WF has nothing to with embedding, since the real flag for that has 2 dashed: --embedding What really happened was that the engine would now be "mbedding" So far there are no clashes for -j or -o which are also valid arguments. Co-authored-by: Benedikt Volkel <[email protected]>
benedikt-voelkel
removed
the
async-2023-pbpb-apass4
benedikt-voelkel
added a commit
to benedikt-voelkel/O2DPG
that referenced
this pull request
May 14, 2024
Without this, passing -embedding would work and produce a workflow.json. However, the resulting WF has nothing to with embedding, since the real flag for that has 2 dashed: --embedding What really happened was that the engine would now be "mbedding" So far there are no clashes for -j or -o which are also valid arguments. Co-authored-by: Benedikt Volkel <[email protected]>
benedikt-voelkel
added a commit
that referenced
this pull request
May 14, 2024
Without this, passing -embedding would work and produce a workflow.json. However, the resulting WF has nothing to with embedding, since the real flag for that has 2 dashed: --embedding What really happened was that the engine would now be "mbedding" So far there are no clashes for -j or -o which are also valid arguments. Co-authored-by: Benedikt Volkel <[email protected]> (cherry picked from commit d8bf2aa)
benedikt-voelkel
added a commit
that referenced
this pull request
May 16, 2024
Without this, passing -embedding would work and produce a workflow.json. However, the resulting WF has nothing to with embedding, since the real flag for that has 2 dashed: --embedding What really happened was that the engine would now be "mbedding" So far there are no clashes for -j or -o which are also valid arguments. Co-authored-by: Benedikt Volkel <[email protected]> (cherry picked from commit d8bf2aa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, passing -embedding would work and produce a workflow.json. However, the resulting WF has nothing to with embedding, since the real flag for that has 2 dashed: --embedding
What really happened was that the engine would now be "mbedding"
So far there are no clashes for -j or -o which are also valid arguments.