Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy a bit and abort as early as possible #1548

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Tidy a bit and abort as early as possible #1548

merged 1 commit into from
Mar 26, 2024

Conversation

benedikt-voelkel
Copy link
Contributor

@benedikt-voelkel benedikt-voelkel commented Mar 22, 2024 •
edited
Loading

  • check for GRID token at the very beginning

  • check for jq tool at the very beginning

  • set a default seed if nothing is given

  • adjust tests

@github-actions GitHub Actions
Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass
async-2023-pp-apass1
async-data
async-mc
async-2022-pp-apass6

@benedikt-voelkel benedikt-voelkel changed the title Tity a bit and abort as early as possible Tidy a bit and abort as early as possible Mar 22, 2024
Tidy a bit and abort as early as possible
df5397f 
* check for GRID token at the very beginning

* check for jq tool at the very beginning

* set a default seed if nothing is given

* adjust tests
@benedikt-voelkel
Copy link
Contributor Author

benedikt-voelkel commented Mar 22, 2024 •
edited
Loading

@catalinristea @chiarazampolli @sawenzel do you have any comments?
In particular, I am trying to make it more and more user-friendly. Now people start using it and run into very basic problems which are often enough hard to spot since the whole execution chain is quite involved as we all know.

@sawenzel sawenzel merged commit 59a5746 into AliceO2Group:master Mar 26, 2024
6 checks passed
@benedikt-voelkel benedikt-voelkel deleted the anchor-tidy branch March 26, 2024 09:59
@chiarazampolli chiarazampolli added the async-2023-pp-apass4 Request porting to async-2023-pp-apass4 label Aug 9, 2024
@chiarazampolli
Copy link
Collaborator

Label async-2023-pp-apass4 added to make the needed PR (#1686) apply

@chiarazampolli chiarazampolli removed the async-2023-pp-apass4 Request porting to async-2023-pp-apass4 label Aug 9, 2024
@chiarazampolli
Copy link
Collaborator

Tag for async-2023-pp-apass4 created, removing label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sawenzel sawenzel sawenzel approved these changes

@chiarazampolli chiarazampolli Awaiting requested review from chiarazampolli chiarazampolli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benedikt-voelkel @chiarazampolli @sawenzel