Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to reduce memory consumption and allow DPG to turn off sampling in validation #1545

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

lauraser
Copy link
Contributor

No description provided.

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass
async-2023-pp-apass1
async-data
async-mc
async-2022-pp-apass6

@lauraser
Copy link
Contributor Author

+async-label async-data

Copy link

Hi @lauraser, due to your association, labels are not added automatically. Probably, this is your first contribution. Please contact one of the reviewers or code owners.

@lauraser
Copy link
Contributor Author

Hi @chiarazampolli , I am contacting you due to the above message about the label association.

@chiarazampolli
Copy link
Collaborator

Hello @lauraser ,
I added the labels for you.
@benedikt-voelkel , will Laura be able to add labels from now on? Even if I don't think that this is her first PR in O2DPG. Does she miss something?
Chiara

@chiarazampolli chiarazampolli merged commit dc0c5bc into AliceO2Group:master Mar 25, 2024
5 of 7 checks passed
@chiarazampolli
Copy link
Collaborator

Merging without waiting for further tests since this is for async data reco only.

@benedikt-voelkel
Copy link
Contributor

@chiarazampolli yes, now labels can be added by @lauraser .
It is only blocked in case of first-time contributions.

@chiarazampolli
Copy link
Collaborator

Perfect, thanks! Even if Laura already had PRs:

https://github.com/AliceO2Group/O2DPG/pulls?q=is%3Apr+author%3A%22lauraser+%22+is%3Aclosed

Chiara

@benedikt-voelkel
Copy link
Contributor

Mh, you are right. I will follow this up in case it happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants