-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Anchor] Add some more help messages #1511
Conversation
benedikt-voelkel
commented
Feb 29, 2024
- help messages
- set ALIEN_JDL_ADDTIMESERIESINMC to a value at the beginning
* help messages * set ALIEN_JDL_ADDTIMESERIESINMC to a value at the beginning
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Ciao @benedikt-voelkel, @chiarazampolli Just a short comment, regarding the use of ALIEN_JDL_ADDTIMESERIESINMC: if we do this in anchorMC.sh, then it will concern only the anchored MC, while we want it for any MC (common, PWG?) right? Isn't it:
Couldn't this be done in the base script o2dpg_sim_workflow.py? Thanks, Catalin. |
Hello, I don't think that this is needed in unanchored MCs. I would even think that unanchored is not needed at all anymore... @miranov25, can you comment? Chiara |
Hello @benedikt-voelkel , Chiara |
It's just for consistency. Of course it would not create problems but this relates somewhat to the "unbound issue" we had although - again - in this case, it would be fine. |
Sure, fine with me, I wanted to make sure that I did not miss anything, since I tagged already without this change. |
I am not sure I understand the comment. For unanchored MC, the time series are indeed useless, but representatively sampled data are useful (I was checking it) |
In any case, that is a different topic: For unanchored we would need to change different things. |
Unanchored should not be used for corrections, which is why i only applied the change to the anchoring script. if needed, let’s take it in another pr. Chiara |
* help messages * set ALIEN_JDL_ADDTIMESERIESINMC to a value at the beginning
* help messages * set ALIEN_JDL_ADDTIMESERIESINMC to a value at the beginning
* help messages * set ALIEN_JDL_ADDTIMESERIESINMC to a value at the beginning
* help messages * set ALIEN_JDL_ADDTIMESERIESINMC to a value at the beginning
* help messages * set ALIEN_JDL_ADDTIMESERIESINMC to a value at the beginning (cherry picked from commit b9cb67a)
Label async-2023-pp-apass4 added to make the needed PR (#1686) apply |
Tag for async-2023-pp-apass4 created, removing label. |