TPC: Add possibility to simulate distortions #1507
Conversation
wiechula
requested review from
sawenzel,
chiarazampolli,
gconesab and
benedikt-voelkel
as code owners
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
wiechula
force-pushed
the
master
branch
2 times, most recently
from
8daa79a to
b145fc3
Compare
|
@chiarazampolli , @sawenzel , shall we go ahead with this? |
|
Hello @wiechula , |
|
@chiarazampolli , I didn't check the numbers in detail. But |
| # in case of PbPb the conversion factor ZDC ->FT0 (pp) must be set | ||
| tpc_corr_options_mc='' | ||
|
|
||
| if tpcDistortionType == 0: # disable distortion corrections |
There was a problem hiding this comment.
In anchored simulations I think these configurations might clash with some we would derive from the anchoring and pass from the outside. I think to be discussed with @sawenzel as well.
| rate = ctpscaler.getRateGivenT(finaltime, ctpclass, ctptype) | ||
| #if ColSystem == "PbPb": | ||
| # rate.first = rate.first / 28. | ||
| # rate.second = rate.second / 28. | ||
|
|
||
| print("Global rate " + str(rate.first) + " local rate " + str(rate.second)) | ||
| scaler = None | ||
| if rate.second >= 0: | ||
| scaler = rate.second | ||
| if rate.first >= 0: |
There was a problem hiding this comment.
@chiarazampolli do you know why we would only return the final/corrected local rate if the global rate is rate.first >= 0? I don't see it being used inside this branch.
There was a problem hiding this comment.
Ciao @benedikt-voelkel ,
I don't know, I am not the author of this part of the code. But I guess that if rate.first is 0, then also rate.second is 0. So it is ok to return none none. Still I agree that it is not very clear.
Chiara
There was a problem hiding this comment.
Was it maybe added here: #1333?
|
Sorry for the delay. I'll take a look asap. |
| tpcLocalCFreco['TPCCorrMap.lumiInstFactor'] = str(lumiInstFactor) | ||
| tpc_corr_options_mc=' --corrmap-lumi-mode 2 ' | ||
| tpcLocalCFreco['TPCCorrMap.lumiInst'] = str(CTPSCALER) |
There was a problem hiding this comment.
This does not correspond to what was done for digitization.
Here, TPCCorrMap.lumiInst and TPCCorrMap.lumiInstFactor are set separately whereas for digitization TPCCorrMap.lumiInst is set directly to the factor.
Is it because the configKey values are digested differently in reconstruction and digitization?
There was a problem hiding this comment.
Indeed, the digizer does not use the lumiInstFactor https://github.com/AliceO2Group/AliceO2/blob/0129938292bf379849ec58652be5c1cfa88e60f1/Detectors/TPC/simulation/src/Digitizer.cxx#L227
While to correction map in reco does: https://github.com/AliceO2Group/AliceO2/blob/0129938292bf379849ec58652be5c1cfa88e60f1/Detectors/TPC/calibration/src/CorrectionMapsLoader.cxx#L201
For reconstruction I wanted to mirror what is done in data. But I assume one could also directly multiply here, right @shahor02 ?
|
|
||
| lumiInstFactor=1 | ||
| if COLTYPE == 'PbPb': | ||
| lumiInstFactor=2.414 |
There was a problem hiding this comment.
Is there no other way to obtain this magic number from some central instance?
|
I have tested this PR and it works for run 544013 (in the range 544013 - 544126). There was slight glitch with From my point of view this can be merged. |
benedikt-voelkel
added
async-2023-pbpb-apass3
async-2023-pbpb-apass4
|
@chiarazampolli , the runs covered are 544013 - 544126, see O2-4531. |
|
Good, thanks! |
Co-authored-by: Sandro Wenzel <[email protected]>
Co-authored-by: Sandro Wenzel <[email protected]>
benedikt-voelkel
removed
the
async-2023-pbpb-apass4
Co-authored-by: Sandro Wenzel <[email protected]> (cherry picked from commit 7188d08)
Requires adding
--tpc-distortion-type 2in the anchorMC script toremainingargsnot done in this PR.