Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files to simulate bbtomuons without forcing semileptonic decay #1504

Merged
merged 6 commits into from
Mar 8, 2024

Conversation

motomioya
Copy link
Contributor

Add files and scripts to simulate bb -> mumu with natural decays. This includes modifications to GeneratorBeautyToMu_EvtGenFwdY().

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass
async-2023-pp-apass1
async-data
async-mc
async-2022-pp-apass6

@benedikt-voelkel
Copy link
Contributor

Approving to steer CI.

@benedikt-voelkel
Copy link
Contributor

Dear @motomioya
I approved to steer the CIs.
Now there is new ini file introduced by your PR: MC/config/PWGDQ/ini/GeneratorHF_bbbarToDDbarToMuons_fwdy.ini
Since these might be used to configure generators in production, we ask for a test that has to be implemented in addition. These tests should be macros that would check that your generator did was is expected.

An example

Documentation: https://aliceo2group.github.io/simulation/docs/generators/generatorconfig.html#generator-tests

Please let me know if you have additional questions.

@motomioya
Copy link
Contributor Author

Dear @benedikt-voelkel
Thank you for the comment. I added a new file to MC/config/PWGDQ/ini/tests/GeneratorHF_bbbarToDDbarToMuons_fwdy.C for the new ini file test. I checked that it works and the test is successful in my local environment.

@benedikt-voelkel
Copy link
Contributor

Amazing, thanks a lot!
I triggered the CI test to run, let's see how it goes!

@benedikt-voelkel benedikt-voelkel merged commit 1cde53e into AliceO2Group:master Mar 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants