Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syntax checkers for Bash and Python #1469

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add syntax checkers for Bash and Python #1469

merged 1 commit into from
Feb 20, 2024

Conversation

TimoWilken
Copy link
Contributor

No description provided.

@TimoWilken
Copy link
Contributor Author

Hi @benedikt-voelkel! I've added some basic checks for Bash and Python scripts -- one with bash -n, one with shellcheck (only showing the errors, no warnings or hints) and one with pylint (only errors as well).

These checkers find some existing problems -- those should probably be fixed before this is merged!

Also, let me know if you don't like any of the checkers, then I can improve or remove it.

I could also enable warning and/or hint messages, but there are quite a lot of them. These won't fail the check but will be shown in the "Files" tab of a PR.

@benedikt-voelkel
Copy link
Contributor

Amazing, thanks a lot!
I will take a look in a bit.

@sawenzel
Copy link
Contributor

This is very good! Thanks a lot.

@benedikt-voelkel benedikt-voelkel mentioned this pull request Feb 19, 2024
Merged
@TimoWilken
Copy link
Contributor Author

Rebased on master to get fixes from #1476. The remaining pylint issue may be spurious, I'll have a look in a bit. The shellcheck ones look genuine.

@martenole martenole mentioned this pull request Feb 20, 2024
Merged
This was referenced Feb 20, 2024
Merged
Merged
TimoWilken added a commit that referenced this pull request Feb 20, 2024
@TimoWilken
Fix Bash syntax issues found by shellcheck
830be70 
Fix issues found in #1469, in
addition to those fixed in #1479.
@TimoWilken TimoWilken mentioned this pull request Feb 20, 2024
Merged
@TimoWilken
Copy link
Contributor Author

Rebased again, thank you @benedikt-voelkel and @martenole! All that's left now is #1479 and #1482.

TimoWilken added a commit that referenced this pull request Feb 20, 2024
@TimoWilken
Fix Bash syntax issues found by shellcheck (#1482)
6d2d239 
Fix issues found in #1469, in
addition to those fixed in #1479.
@TimoWilken
Copy link
Contributor Author

Rebased; CI is all green now!

@TimoWilken TimoWilken merged commit ba2ab94 into master Feb 20, 2024
10 checks passed
@TimoWilken TimoWilken deleted the syntax-checkers branch February 20, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benedikt-voelkel benedikt-voelkel benedikt-voelkel approved these changes

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

@martenole martenole Awaiting requested review from martenole

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

@chiarazampolli chiarazampolli Awaiting requested review from chiarazampolli chiarazampolli is a code owner

@sawenzel sawenzel Awaiting requested review from sawenzel sawenzel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimoWilken @benedikt-voelkel @sawenzel