[OMON-661] Remove division by 0 log message (#319)

AliceO2Group · Oct 6, 2023 · 2f917a2 · 2f917a2
1 parent 2daddd2
commit 2f917a2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -31,7 +31,7 @@ endif()
 
 # Define project
 project(Monitoring
-  VERSION 3.17.3
+  VERSION 3.17.4
   DESCRIPTION "O2 Monitoring library"
   LANGUAGES CXX
 )

diff --git a/src/DerivedMetrics.cxx b/src/DerivedMetrics.cxx
@@ -80,7 +80,7 @@ bool DerivedMetrics::process(Metric& metric, DerivedMetricMode mode)
        int timestampCount = timestampDifference.count();
        // disallow dividing by 0
        if (timestampCount == 0) {
-         throw MonitoringException("DerivedMetrics", "Division by 0 when calculating rate for: " + metric.getName() + "/" + metric.getFirstValue().first);
+         //throw MonitoringException("DerivedMetrics", "Division by 0 when calculating rate for: " + metric.getName() + "/" + metric.getFirstValue().first);
        }
 
        auto current = metric.getFirstValue().second;

diff --git a/test/testDerived.cxx b/test/testDerived.cxx
@@ -171,15 +171,15 @@ bool exceptionCheck(const MonitoringException& e)
   return false;
 }
 
-BOOST_AUTO_TEST_CASE(divisionByZero)
+/*BOOST_AUTO_TEST_CASE(divisionByZero)
 {
   std::string name("test");
   o2::monitoring::DerivedMetrics derivedHandler;
   o2::monitoring::Metric metric(10, name);
 
   derivedHandler.process(metric, DerivedMetricMode::RATE);
   BOOST_CHECK_EXCEPTION(derivedHandler.process(metric, DerivedMetricMode::RATE), MonitoringException, exceptionCheck);
-}
+}*/
 
 BOOST_AUTO_TEST_CASE(derivedIncrementInt)
 {