-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nanosecond timestamp + workflow info to environment events #607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good for me, but I will wait for Martin or George's confirmation before merging.
@knopers8 So if I understood correctly, if |
@martinboulais I would even go further, I would require |
This seems a bit too hacky to me, no? I don't really like the hardcoded values like this, especially when it's from another service. |
But then I think we want to deprecate it anyway, but to me this is irrelevant to the fact, that we may want to run an environment which is not used for data-taking, but it should be possible to do that with COG. |
What I think would be the best is to add another field/variable in the templates such as |
@knopers8 @martinboulais I think the suggestion to add a new field makes a lot of sense. The current |
@vascobarroso @knopers8 I agree that adding a new field makes quite some sense to me. |
22c2f1b
to
fe45651
Compare
@knopers8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
This PR does 2 things:
WorkflowTemplateInfo
field to allEnvironmentEvent
s pushed to Kafka, that includes the public trait of the workflow template as requested, plus the name, description and workflow path.timestampNano
to all events pushed to Kafka. The timestamp itself is identical to the existing ms timestamp, it is just outputted with higher precision.@martinboulais @graduta