Skip to content

Commit

Permalink
[core] do not warn about tasks not in roster when it's expected
Browse files Browse the repository at this point in the history
When scheduling a task kill, we remove it from roster.
Thus, when we receive a task state DONE update, there is typically nothing to warn about.

OCTRL-940
  • Loading branch information
knopers8 committed Jan 10, 2025
1 parent c46119c commit 90fb4b0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion core/task/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -960,9 +960,10 @@ func (m *Manager) GetTask(id string) *Task {

func (m *Manager) updateTaskState(taskId string, state string) {
taskPtr := m.roster.getByTaskId(taskId)
if taskPtr == nil {
if taskPtr == nil && state != "DONE" {
log.WithField("taskId", taskId).
WithField("state", state).
WithField(infologger.Level, infologger.IL_Support).
Warn("attempted state update of task not in roster")
return
}
Expand Down

0 comments on commit 90fb4b0

Please sign in to comment.