Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1420] Add CTP readout host to FLP hosts #1838

Merged

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Add CTP host to flp roles if CTP is enabled

Notable changes for developers:

  • N/A

Changes made to the database:

  • N/A

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.12%. Comparing base (0028a29) to head (ec71a6b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
+ Coverage   44.08%   44.12%   +0.03%     
==========================================
  Files         891      891              
  Lines       15922    15927       +5     
  Branches     3006     3008       +2     
==========================================
+ Hits         7019     7027       +8     
+ Misses       8903     8900       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

graduta
graduta previously approved these changes Jan 22, 2025
Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick action on this. Do you think there is a small space where you could add the logic behind this chance as documentation?

@martinboulais martinboulais merged commit 6d7dec2 into main Jan 23, 2025
23 checks passed
@martinboulais martinboulais deleted the mboulais/O2B-1420/add-ctp-readout-host-to-flp-hosts branch January 23, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants