Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1290] Multi run flagging frontend #1833

Open
wants to merge 61 commits into
base: main
Choose a base branch
from

Conversation

Jaden505
Copy link
Collaborator

@Jaden505 Jaden505 commented Jan 15, 2025

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for developers:

  • QC flag creation page query params now accept a map of run numbers and detector ids instead of separate query params.

…of the backend to accept multiple run ids and detector ids
…d to work with no new endpoint. set multiple button now actually correct redirects
@Jaden505 Jaden505 self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 151 lines in your changes missing coverage. Please review.

Project coverage is 43.58%. Comparing base (2031879) to head (6be304c).

Files with missing lines Patch % Lines
...public/views/QcFlags/Create/QcFlagCreationModel.js 0.00% 68 Missing ⚠️
lib/public/views/QcFlags/QcFlagsModel.js 0.00% 28 Missing ⚠️
...ic/views/QcFlags/Create/qcFlagCreationComponent.js 0.00% 18 Missing ⚠️
...uns/RunPerDataPass/RunsPerDataPassOverviewModel.js 0.00% 16 Missing ⚠️
...b/public/components/qcFlags/qcFlagsPagesButtons.js 0.00% 6 Missing ⚠️
...reate/forDataPass/QcFlagCreationForDataPassPage.js 0.00% 4 Missing ⚠️
...ulationPass/QcFlagCreationForSimulationPassPage.js 0.00% 4 Missing ⚠️
lib/public/components/qcFlags/isRunSubjectToQc.js 0.00% 3 Missing ⚠️
...eate/forDataPass/QcFlagCreationForDataPassModel.js 0.00% 1 Missing ⚠️
...lationPass/QcFlagCreationForSimulationPassModel.js 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1833      +/-   ##
==========================================
- Coverage   43.86%   43.58%   -0.29%     
==========================================
  Files         891      891              
  Lines       15971    16061      +90     
  Branches     3020     3049      +29     
==========================================
- Hits         7006     7000       -6     
- Misses       8965     9061      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/public/components/qcFlags/isRunSubjectToQc.js Outdated Show resolved Hide resolved
lib/public/components/qcFlags/qcFlagsBreadcrumbs.js Outdated Show resolved Hide resolved
lib/public/components/qcFlags/qcFlagsBreadcrumbs.js Outdated Show resolved Hide resolved
lib/public/components/qcFlags/qcFlagsPagesButtons.js Outdated Show resolved Hide resolved
lib/server/routers/runs.router.js Outdated Show resolved Hide resolved
@Jaden505 Jaden505 changed the title [O2B-1290] multi run flagging frontend [O2B-1290] Multi run flagging frontend Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants